Closed Bug 1582127 Opened 5 years ago Closed 2 years ago

The PiP toggle button is cut off on Facebook videos

Categories

(Toolkit :: Picture-in-Picture, defect, P3)

Desktop
All
defect

Tracking

()

RESOLVED INVALID
Tracking Status
firefox69 --- disabled
firefox70 --- affected
firefox71 --- affected
firefox72 --- affected
firefox73 --- affected
firefox74 --- affected
firefox75 --- affected
firefox76 --- affected

People

(Reporter: tbabos, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Attached image Toggle button.png

Affected versions:
Nightly 71.0a1 (2019-09-17) (64-bit)
Beta 71.0b7

Affected platforms:
Windows 7/10

Steps to reproduce:

Expected result:
The PiP icon and toggle should be correctly displayed when the user hovers over the video or the button

Actual Result:
The PiP icon and toggle button is cut off when the user hovers over the video or the button

Attached image Icon

There's an added step here - one needs to click on the video in order to have it "zoom" and have the frame gain a scrollbar (which overlaps the toggle).

So it looks like Facebook is intentionally allowing the right side of the <video> element to fall behind the vertical scroll bar. The scrollable region has overflow: hidden, so the user is unable to manually scroll to the right to fully expose the toggle.

I'm setting this as a P3 for now, since it's technically still possible to access PiP even with the video being overlapped by this, though it becomes a little more difficult. What do you think, astevenson?

Flags: needinfo?(astevenson)
Priority: -- → P3

I agree. It seems like FB could size the video element to not fall behind the scroll bar. If this is an issue in the future we can talk to FB about it.

Flags: needinfo?(astevenson)

We could also potentially use the WebCompat add-on to add an intervention for this site.

Blocks: 1532675
No longer blocks: 1527926

Build ID 20191124230652
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:72.0) Gecko/20100101 Firefox/72.0

Reproducible also on Nightly 72 on macOS 10.13 platform.

OS: Windows 10 → All
Hardware: All → Desktop
No longer blocks: 1532675

This issue is still reproducible using Latest Nightly build 74.0a1 (02-04-2020) and Beta 73.0. Changed the flags accordingly.

I was able to reproduce this issue on Latest Nightly version 75.0a1 on macOS 10.14 using this video https://www.facebook.com/thedodosite/videos/578690349533713/. Changed the flags accordingly.

I can reproduce the issue with the classic Facebook layout, but not in the new Beta layout. Could someone confirm this for me please?

It's possibly a lower priority if it's specific to the classic layout.

This issue is still reproducible using Latest Nightly build 76.0a1 (16-03-2020) Changed the flags accordingly.

Hi Seba, were you testing with the classic Facebook layout or the new one?

Flags: needinfo?(sebastian.scherer)

Hi Adam! Confirmed, only happening on classic layout, couldn´t reproduce on the new one.

Regards,

Flags: needinfo?(sebastian.scherer)
Component: Video/Audio Controls → Picture-in-Picture
Version: unspecified → Trunk

I can't reproduce this on Nightly 96.0a1 on macOS or Windows.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: