1582127 - The PiP toggle button is cut off on Facebook videos

Status: RESOLVED INVALID

(Toolkit :: Picture-in-Picture, defect, P3)

Description

[Timea Cernea [:tbabos][inactive]]

Attachment: Toggle button.png

Affected versions:
Nightly 71.0a1 (2019-09-17) (64-bit)
Beta 71.0b7

Affected platforms:
Windows 7/10

Steps to reproduce:

• Launch Nightly or Beta
• Go to a facebook video, such as
  https://www.facebook.com/9gag/videos/3249706955069723/
• Hover over the video and check out the PiP icon
• Hover over the toggle button

Expected result:
The PiP icon and toggle should be correctly displayed when the user hovers over the video or the button

Actual Result:
The PiP icon and toggle button is cut off when the user hovers over the video or the button

Comment 1

[Timea Cernea [:tbabos][inactive]]

Attachment: Icon

Comment 2

[Mike Conley (:mconley) (:⚙️)]

There's an added step here - one needs to click on the video in order to have it "zoom" and have the frame gain a scrollbar (which overlaps the toggle).

Comment 3

[Mike Conley (:mconley) (:⚙️)]

So it looks like Facebook is intentionally allowing the right side of the <video> element to fall behind the vertical scroll bar. The scrollable region has overflow: hidden, so the user is unable to manually scroll to the right to fully expose the toggle.

I'm setting this as a P3 for now, since it's technically still possible to access PiP even with the video being overlapped by this, though it becomes a little more difficult. What do you think, astevenson?

Comment 4

[Adam Stevenson [:adamopenweb]]

I agree. It seems like FB could size the video element to not fall behind the scroll bar. If this is an issue in the future we can talk to FB about it.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

We could also potentially use the WebCompat add-on to add an intervention for this site.

Comment 6

[Cristian Craciun]

Build ID 20191124230652
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:72.0) Gecko/20100101 Firefox/72.0

Reproducible also on Nightly 72 on macOS 10.13 platform.

Comment 8

[Alin Ilea, Desktop Test Engineering]

This issue is still reproducible using Latest Nightly build 74.0a1 (02-04-2020) and Beta 73.0. Changed the flags accordingly.

Comment 9

[Marcela (Please NI request to Brindusa Tot)]

I was able to reproduce this issue on Latest Nightly version 75.0a1 on macOS 10.14 using this video https://www.facebook.com/thedodosite/videos/578690349533713/. Changed the flags accordingly.

Comment 10

[Adam Stevenson [:adamopenweb]]

I can reproduce the issue with the classic Facebook layout, but not in the new Beta layout. Could someone confirm this for me please?

It's possibly a lower priority if it's specific to the classic layout.

Comment 11

[Seba S.]

This issue is still reproducible using Latest Nightly build 76.0a1 (16-03-2020) Changed the flags accordingly.

Comment 12

[Adam Stevenson [:adamopenweb]]

Hi Seba, were you testing with the classic Facebook layout or the new one?

Comment 13

[Seba S.]

Hi Adam! Confirmed, only happening on classic layout, couldn´t reproduce on the new one.

Regards,

Comment 14

[Ania]

I can't reproduce this on Nightly 96.0a1 on macOS or Windows.