1582231 - Remove Moz2D dependency on Cairo glyph extents

Status: RESOLVED FIXED

(Core :: Graphics: Text, enhancement, P3)

Description

[Lee Salzman [:lsalzman]]

As a follow-up to bug 1547063, it turns on that a further dependency on Cairo's glyph extents was hidden inside Moz2D.

This replaces that dependency with direct calls to query glyph bounds from the relevant APIs, all of this on the gfxFonts inside thebes, so that we don't have to descend into Moz2D across the information-loss barrier there or construct new Moz2D objects to do things. In many cases, we already have some of the metrics information available inside the gfxFonts already, so we get to reuse that now.

It also turns out that we have a gfxGlyphExtents caching layer that duplicates Cairo's own glyph metrics caching, so this should be a win in terms of resource usage.

I have endeavored to just try to faithfully reproduce the behavior of Cairo under the hood by in most cases just reproducing the code flow that was in Cairo (primarily inside the mess that is gfxGDIFont).

Comment 1

[Lee Salzman [:lsalzman]]

Attachment: Bug 1582231 - remove Moz2D dependency on Cairo glyph extents. r?jfkthame

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1b851fdff16
remove Moz2D dependency on Cairo glyph extents. r=jfkthame

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/a1b851fdff16