Closed Bug 1582265 Opened 4 years ago Closed 4 years ago

[Protection Report] Polish animations

Categories

(Firefox :: Protections UI, enhancement, P1)

Product:
Firefox
Component:
Protections UI
Version:
70 Branch
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 71
Tracking Flags:
Tracking Status
firefox70 --- fixed
firefox71 --- fixed

People

(Reporter: ewright, Assigned: ewright)

References

Details

Attachments

(1 file)

Bug 1582265 - Add animations to the bar graph.
47 bytes, text/x-phabricator-request
lizzard
: approval-mozilla-beta+
Details | Review

Add an animation to the graph bars to make the report feel a little more polished.

Pushed by ewright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a4110ca661ce
Add animations to the bar graph. r=johannh

https://hg.mozilla.org/mozilla-central/rev/a4110ca661ce

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

Comment on attachment 9093732 [details]
Bug 1582265 - Add animations to the bar graph.

Beta/Release Uplift Approval Request

  • User impact if declined: graph will have no animation.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): add animation to the graph with CSS and JS. Simple patch.
  • String changes made/needed: none
Attachment #9093732 - Flags: approval-mozilla-beta?

Comment on attachment 9093732 [details]
Bug 1582265 - Add animations to the bar graph.

Polish for skyline feature, let's take it for beta 10.

Attachment #9093732 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.