1582273 - Add scroll bar primitive flags to items in the Gecko WR display list

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Glenn Watson [:gw]]

Now that https://bugzilla.mozilla.org/show_bug.cgi?id=1581448 has landed, the Gecko WR display list code can be updated to provide the extra information about scroll bars.

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: wrscrollbarflags

Comment 2

[Timothy Nikkel (:tnikkel)]

Let me know if this is what you were looking for.

Comment 3

[Glenn Watson [:gw]]

Yep, this looks good!

I applied the patch, built and did a WR capture. The resulting scene.ron file has the bits set on the scroll bar stacking contexts.

I only tested on Linux, but I think we can get this reviewed and merged. We can always iterate on it in future if other platforms differ.

Thanks!

Comment 4

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1582273. Pass scrollbar flags from gecko to webrender so it can identify them. r=gw

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0574bc97e2ac
Pass scrollbar flags from gecko to webrender so it can identify them. r=gw

Comment 6

[Noemi Erli[:noemi_erli]]

Backed out changeset 0574bc97e2ac (Bug 1582273) for causing wrench build bustages CLOSED TREE

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=268043903&resultStatus=testfailed%2Cbusted%2Cexception&revision=0574bc97e2acf6cc55ab12306b489787e2a58796

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=268043850&repo=autoland
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=268043903&repo=autoland&lineNumber=7562

Backout: https://hg.mozilla.org/integration/autoland/rev/9b603aca92aaced86316be122ebe377161943cbc

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da5d5eb153f2
Pass scrollbar flags from gecko to webrender so it can identify them. r=gw

Comment 8

[Arthur Iakab [arthur_iakab]]

Backed out changeset da5d5eb153f2 (bug 1582273) for causing tidy bustages. CLOSED TRE

Backout revision https://hg.mozilla.org/integration/autoland/rev/fc1980f07d3042f2d2940423a0cb46ad23967482

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=da5d5eb153f2c58c857d855512089732a78ac2bb&selectedJob=268070333&searchStr=Linux%2Cx64%2CQuantumRender%2Copt%2CWebRender%2Cstandalone%2Cwebrender-lint-tidy%2CWR%28tidy%29

Failure logs https://treeherder.mozilla.org/logviewer.html#?job_id=268070333&repo=autoland

Timothy can you please take a look?

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9b09f4047b8
Pass scrollbar flags from gecko to webrender so it can identify them. r=gw

Comment 10

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/e9b09f4047b8