Closed Bug 1582273 Opened 7 months ago Closed 7 months ago

Add scroll bar primitive flags to items in the Gecko WR display list

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: gw, Assigned: tnikkel)

Details

Attachments

(1 file, 1 obsolete file)

Now that https://bugzilla.mozilla.org/show_bug.cgi?id=1581448 has landed, the Gecko WR display list code can be updated to provide the extra information about scroll bars.

Attached patch wrscrollbarflags (obsolete) — Splinter Review

Let me know if this is what you were looking for.

Flags: needinfo?(gwatson)

Yep, this looks good!

I applied the patch, built and did a WR capture. The resulting scene.ron file has the bits set on the scroll bar stacking contexts.

I only tested on Linux, but I think we can get this reviewed and merged. We can always iterate on it in future if other platforms differ.

Thanks!

Flags: needinfo?(gwatson)
Attachment #9094093 - Attachment is obsolete: true
Assignee: nobody → tnikkel
Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0574bc97e2ac
Pass scrollbar flags from gecko to webrender so it can identify them. r=gw
Flags: needinfo?(tnikkel)
Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/da5d5eb153f2
Pass scrollbar flags from gecko to webrender so it can identify them. r=gw
Attachment #9094161 - Attachment description: Bug 1582273. Pass scrollbar flags from gecko to webrender so it can identify them. → Bug 1582273. Pass scrollbar flags from gecko to webrender so it can identify them. r=gw
Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e9b09f4047b8
Pass scrollbar flags from gecko to webrender so it can identify them. r=gw
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Flags: needinfo?(tnikkel)
You need to log in before you can comment on or make changes to this bug.