Closed Bug 1582288 Opened 1 year ago Closed 1 year ago

15,500 instances of "Attempting to get a displayport from a content with no primary frame!" emitted from layout/base/nsLayoutUtils.cpp during linux64 debug testing

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: erahm, Assigned: tnikkel)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1582288. Don't get the display port in nsLayoutUtils::SetDisplayPortMargins when we don't need it because we don't have a frame. r?botond
47 bytes, text/x-phabricator-request
Details | Review

15488 WARNING: Attempting to get a displayport from a content with no primary frame!: file layout/base/nsLayoutUtils.cpp, line 767

This warning [1] shows up in the following test suites:

   276 - test-linux64/debug-mochitest-browser-chrome-e10s-9 bc9
   270 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-10 bc10
   268 - test-linux64/debug-web-platform-tests-e10s-8 wpt8
   268 - test-linux64/debug-web-platform-tests-sw-e10s-8 wpt8
   233 - test-linux64/debug-web-platform-tests-wdspec-e10s-1 Wd1
   233 - test-linux64/debug-web-platform-tests-wdspec-sw-e10s-1 Wd1
   179 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-7 bc7
   168 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-16 bc16
   168 - test-linux64/debug-mochitest-browser-chrome-e10s-16 bc16
   166 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-16 bc16
   162 - test-linux64/debug-reftest-e10s-7 R7
   162 - test-linux64/debug-reftest-e10s-5 R5
   162 - test-linux64/debug-reftest-sw-e10s-7 R7
   162 - test-linux64/debug-reftest-sw-e10s-5 R5
   162 - test-linux64/debug-reftest-no-accel-sw-e10s-7 Ru7
   162 - test-linux64/debug-reftest-no-accel-e10s-5 Ru5
   162 - test-linux64/debug-reftest-no-accel-sw-e10s-5 Ru5
   162 - test-linux64/debug-reftest-no-accel-e10s-7 Ru7
   160 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-3 Wr3
   159 - test-linux64/debug-reftest-no-accel-e10s-1 Ru1
   159 - test-linux64/debug-reftest-e10s-2 R2
   159 - test-linux64/debug-reftest-sw-e10s-1 R1
   159 - test-linux64/debug-reftest-no-accel-e10s-2 Ru2
   159 - test-linux64/debug-reftest-e10s-1 R1
   159 - test-linux64/debug-reftest-no-accel-sw-e10s-1 Ru1
   159 - test-linux64/debug-reftest-e10s-6 R6
   159 - test-linux64/debug-reftest-no-accel-e10s-6 Ru6
   159 - test-linux64/debug-reftest-no-accel-sw-e10s-6 Ru6
   159 - test-linux64/debug-reftest-no-accel-sw-e10s-2 Ru2
   159 - test-linux64/debug-web-platform-tests-reftests-e10s-3 Wr3
   159 - test-linux64/debug-reftest-sw-e10s-2 R2
   159 - test-linux64/debug-reftest-sw-e10s-6 R6
   156 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-2 Wr2
   155 - test-linux64/debug-mochitest-browser-chrome-e10s-10 bc10
   155 - test-linux64/debug-web-platform-tests-reftests-e10s-2 Wr2
   150 - test-linux64/debug-reftest-no-accel-sw-e10s-3 Ru3
   150 - test-linux64/debug-reftest-sw-e10s-3 R3
   150 - test-linux64/debug-reftest-e10s-3 R3
   150 - test-linux64/debug-reftest-no-accel-e10s-3 Ru3
   148 - test-linux64/debug-web-platform-tests-wdspec-sw-e10s-2 Wd2
   148 - test-linux64/debug-mochitest-browser-chrome-e10s-8 bc8
   148 - test-linux64/debug-web-platform-tests-reftests-e10s-1 Wr1
   148 - test-linux64/debug-web-platform-tests-wdspec-e10s-2 Wd2
   147 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-1 Wr1
   141 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-7 bc7
   140 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-1 bc1
   138 - test-linux64/debug-web-platform-tests-reftests-e10s-4 Wr4
   138 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-4 Wr4
   135 - test-linux64/debug-reftest-no-accel-sw-e10s-4 Ru4
   135 - test-linux64/debug-reftest-no-accel-e10s-4 Ru4
   135 - test-linux64/debug-reftest-sw-e10s-4 R4
   135 - test-linux64/debug-reftest-e10s-4 R4
   124 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-12 bc12
   119 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-15 bc15
   119 - test-linux64/debug-mochitest-browser-chrome-e10s-15 bc15
   112 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-15 bc15
    98 - test-linux64/debug-mochitest-browser-chrome-e10s-13 bc13
    98 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-13 bc13
    92 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-3 bc3
    92 - test-linux64/debug-mochitest-browser-chrome-e10s-14 bc14
    92 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-14 bc14
    92 - test-linux64/debug-web-platform-tests-sw-e10s-14 wpt14
    91 - test-linux64/debug-web-platform-tests-e10s-14 wpt14
    87 - test-linux64/debug-mochitest-browser-chrome-e10s-12 bc12
    86 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-14 bc14
    84 - test-linux64/debug-mochitest-browser-chrome-e10s-4 bc4
    79 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-8 bc8
    79 - test-linux64/debug-marionette-e10s Mn
    72 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-6 bc6
    71 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-11 bc11
    71 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-6 bc6
    70 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-12 bc12
    68 - test-linux64/debug-web-platform-tests-sw-e10s-16 wpt16
    68 - test-linux64/debug-web-platform-tests-e10s-16 wpt16
    67 - test-linux64/debug-mochitest-browser-chrome-e10s-7 bc7
    66 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-3 dt3
    65 - test-linux64/debug-mochitest-devtools-chrome-e10s-3 dt3
    65 - test-linux64/debug-mochitest-browser-chrome-e10s-1 bc1
    65 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-3 dt3
    63 - test-linux64/debug-web-platform-tests-sw-e10s-5 wpt5
    63 - test-linux64/debug-web-platform-tests-e10s-5 wpt5
    62 - test-linux64/debug-mochitest-e10s-2 2
    62 - test-linux64/debug-mochitest-browser-chrome-e10s-3 bc3
    62 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-4 bc4
    62 - test-linux64/debug-mochitest-browser-chrome-e10s-6 bc6
    62 - test-linux64/debug-mochitest-sw-e10s-2 2
    61 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-5 bc5
    61 - test-linux64/debug-web-platform-tests-e10s-3 wpt3
    61 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-9 bc9
    60 - test-linux64/debug-web-platform-tests-sw-e10s-3 wpt3
    60 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-2 bc2
    59 - test-linux64/debug-web-platform-tests-e10s-4 wpt4
    57 - test-linux64/debug-mochitest-browser-chrome-e10s-2 bc2
    57 - test-linux64/debug-web-platform-tests-sw-e10s-9 wpt9
    57 - test-linux64/debug-web-platform-tests-sw-e10s-4 wpt4
    57 - test-linux64/debug-web-platform-tests-e10s-9 wpt9
    57 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-13 bc13
    56 - test-linux64/debug-web-platform-tests-e10s-10 wpt10
    56 - test-linux64/debug-web-platform-tests-sw-e10s-10 wpt10
    56 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-2 bc2
    55 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-5 bc5
    55 - test-linux64/debug-web-platform-tests-sw-e10s-1 wpt1
    55 - test-linux64/debug-web-platform-tests-e10s-2 wpt2
    55 - test-linux64/debug-web-platform-tests-sw-e10s-2 wpt2
    55 - test-linux64/debug-web-platform-tests-e10s-1 wpt1
    54 - test-linux64/debug-web-platform-tests-sw-e10s-7 wpt7
    54 - test-linux64/debug-web-platform-tests-sw-e10s-12 wpt12
    54 - test-linux64/debug-web-platform-tests-e10s-12 wpt12
    54 - test-linux64/debug-web-platform-tests-e10s-15 wpt15
    53 - test-linux64/debug-web-platform-tests-e10s-7 wpt7
    53 - test-linux64/debug-web-platform-tests-sw-e10s-15 wpt15
    53 - test-linux64/debug-web-platform-tests-sw-e10s-18 wpt18
    53 - test-linux64/debug-web-platform-tests-e10s-18 wpt18
    51 - test-linux64/debug-firefox-ui-functional-local-e10s en-US
    51 - test-linux64/debug-web-platform-tests-e10s-6 wpt6
    50 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-1 bc1
    50 - test-linux64/debug-web-platform-tests-e10s-17 wpt17
    50 - test-linux64/debug-web-platform-tests-e10s-11 wpt11
    50 - test-linux64/debug-web-platform-tests-sw-e10s-13 wpt13
    50 - test-linux64/debug-web-platform-tests-sw-e10s-17 wpt17
    50 - test-linux64/debug-web-platform-tests-sw-e10s-11 wpt11
    50 - test-linux64/debug-web-platform-tests-sw-e10s-6 wpt6
    50 - test-linux64/debug-web-platform-tests-e10s-13 wpt13
    49 - test-linux64/debug-mochitest-browser-chrome-e10s-5 bc5
    49 - test-linux64/debug-mochitest-devtools-chrome-e10s-8 dt8
    49 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-8 dt8
    48 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-4 bc4
    46 - test-linux64/debug-mochitest-sw-e10s-5 5
    46 - test-linux64/debug-mochitest-fis-e10s-5 5
    46 - test-linux64/debug-mochitest-e10s-5 5
    44 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-9 bc9
    44 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-8 bc8
    43 - test-linux64/debug-mochitest-e10s-15 15
    43 - test-linux64/debug-mochitest-sw-e10s-15 15
    41 - test-linux64/debug-mochitest-browser-chrome-e10s-11 bc11
    41 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-11 bc11
    39 - test-linux64/debug-mochitest-fis-e10s-15 15
    38 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-8 dt8
    32 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-3 bc3
    31 - test-linux64/debug-mochitest-sw-e10s-8 8
    31 - test-linux64/debug-mochitest-media-spi-e10s-1 mda1
    31 - test-linux64/debug-mochitest-e10s-8 8
    31 - test-linux64/debug-mochitest-media-fis-e10s-1 mda1
    31 - test-linux64/debug-mochitest-media-sw-e10s-1 mda1
    31 - test-linux64/debug-mochitest-media-e10s-1 mda1
    28 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-6 dt6
    28 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-4 dt4
    28 - test-linux64/debug-mochitest-devtools-chrome-e10s-7 dt7
    25 - test-linux64/debug-mochitest-fis-e10s-8 8
    24 - test-linux64/debug-mochitest-devtools-chrome-e10s-4 dt4
    24 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-2 dt2
    24 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-7 dt7
    23 - test-linux64/debug-mochitest-e10s-6 6
    23 - test-linux64/debug-mochitest-sw-e10s-6 6
    23 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-5 dt5
    23 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-5 dt5
    23 - test-linux64/debug-mochitest-fis-e10s-6 6
    23 - test-linux64/debug-mochitest-devtools-chrome-e10s-6 dt6
    22 - test-linux64/debug-mochitest-fis-e10s-2 2
    21 - test-linux64/debug-mochitest-e10s-14 14
    21 - test-linux64/debug-mochitest-sw-e10s-14 14
    20 - test-linux64/debug-mochitest-e10s-16 16
    20 - test-linux64/debug-mochitest-sw-e10s-16 16
    20 - test-linux64/debug-mochitest-fis-e10s-14 14
    19 - test-linux64/debug-mochitest-sw-e10s-1 1
    19 - test-linux64/debug-mochitest-fis-e10s-1 1
    19 - test-linux64/debug-mochitest-fis-e10s-9 9
    19 - test-linux64/debug-mochitest-fis-e10s-4 4
    19 - test-linux64/debug-mochitest-e10s-9 9
    19 - test-linux64/debug-mochitest-fis-e10s-16 16
    19 - test-linux64/debug-mochitest-sw-e10s-9 9
    19 - test-linux64/debug-mochitest-e10s-1 1
    19 - test-linux64/debug-mochitest-fis-e10s-13 13
    18 - test-linux64/debug-mochitest-sw-e10s-13 13
    18 - test-linux64/debug-mochitest-e10s-13 13
    17 - test-linux64/debug-mochitest-sw-e10s-4 4
    17 - test-linux64/debug-mochitest-e10s-4 4
    15 - test-linux64/debug-crashtest-e10s C
    15 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-10 bc10
    15 - test-linux64/debug-crashtest-sw-e10s C
    14 - test-linux64/debug-telemetry-tests-client-e10s c
    13 - test-linux64/debug-mochitest-sw-e10s-12 12
    13 - test-linux64/debug-mochitest-e10s-12 12
    13 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-6 dt6
    12 - test-linux64/debug-mochitest-e10s-11 11
    12 - test-linux64/debug-mochitest-devtools-chrome-e10s-2 dt2
    12 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-2 dt2
    12 - test-linux64/debug-mochitest-fis-e10s-12 12
    12 - test-linux64/debug-mochitest-sw-e10s-11 11
    12 - test-linux64/debug-mochitest-fis-e10s-11 11
    11 - test-linux64/debug-mochitest-e10s-3 3
    11 - test-linux64/debug-mochitest-devtools-chrome-e10s-1 dt1
    11 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-4 dt4
    11 - test-linux64/debug-mochitest-fis-e10s-3 3
    11 - test-linux64/debug-mochitest-devtools-chrome-e10s-5 dt5
    11 - test-linux64/debug-mochitest-sw-e10s-3 3
    10 - test-linux64/debug-mochitest-sw-e10s-10 10
    10 - test-linux64/debug-mochitest-sw-e10s-7 7
    10 - test-linux64/debug-mochitest-e10s-7 7
    10 - test-linux64/debug-mochitest-fis-e10s-7 7
    10 - test-linux64/debug-mochitest-e10s-10 10
     9 - test-linux64/debug-mochitest-fis-e10s-10 10
     9 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-7 dt7
     9 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-1 dt1
     9 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-1 dt1
     9 - test-linux64/debug-mochitest-devtools-chrome-e10s-10 dt10
     8 - test-linux64/debug-mochitest-media-spi-e10s-3 mda3
     8 - test-linux64/debug-mochitest-media-fis-e10s-3 mda3
     8 - test-linux64/debug-mochitest-media-sw-e10s-3 mda3
     8 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-12 dt12
     8 - test-linux64/debug-mochitest-media-e10s-3 mda3
     8 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-12 dt12
     7 - test-linux64/debug-mochitest-media-spi-e10s-2 mda2
     7 - test-linux64/debug-mochitest-devtools-chrome-e10s-12 dt12
     7 - test-linux64/debug-mochitest-media-e10s-2 mda2
     7 - test-linux64/debug-mochitest-media-sw-e10s-2 mda2
     7 - test-linux64/debug-mochitest-media-fis-e10s-2 mda2
     6 - test-linux64/debug-reftest-e10s-8 R8
     6 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-9 dt9
     6 - test-linux64/debug-reftest-no-accel-sw-e10s-8 Ru8
     6 - test-linux64/debug-reftest-no-accel-e10s-8 Ru8
     6 - test-linux64/debug-mochitest-devtools-chrome-e10s-9 dt9
     6 - test-linux64/debug-reftest-sw-e10s-8 R8
     6 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-10 dt10
     6 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-9 dt9
     5 - test-linux64/debug-mochitest-webgl1-core-sw-e10s gl1c
     5 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-11 dt11
     5 - test-linux64/debug-mochitest-webgl1-core-e10s gl1c
     5 - test-linux64/debug-mochitest-gpu-sw-e10s gpu
     5 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-10 dt10
     5 - test-linux64/debug-mochitest-devtools-chrome-e10s-11 dt11
     5 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-11 dt11
     5 - test-linux64/debug-mochitest-webgl1-core-fis-e10s gl1c
     5 - test-linux64/debug-mochitest-gpu-e10s gpu
     3 - test-linux64/debug-mochitest-remote-sw-e10s remote
     3 - test-linux64/debug-mochitest-remote-e10s remote
     1 - test-linux64/debug-marionette-media-e10s MnM
     1 - test-linux64/debug-mochitest-webgl1-ext-sw-e10s gl1e
     1 - test-linux64/debug-mochitest-webgl1-ext-e10s gl1e
     1 - test-linux64/debug-mochitest-webgl1-ext-fis-e10s gl1e
     1 - test-linux64/debug-firefox-ui-functional-remote-e10s en-US

It shows up in 2938 tests. A few of the most prevalent:

  1600 - [e10s] Shutdown
   168 - [e10s] dom/tests/browser/browser_noopener.js
    88 - [e10s] toolkit/components/antitracking/test/browser/browser_blockingMessaging.js
    84 - [e10s] browser/base/content/test/general/browser_newWindowDrop.js
    63 - [e10s] dom/html/test/test_fullscreen-api.html
    54 - [e10s] /webdriver/tests/new_session/create_alwaysMatch.py
    54 - [e10s] /webdriver/tests/new_session/create_firstMatch.py
    52 - [e10s] dom/media/test/test_autoplay_policy_activation.html
    51 - [e10s] browser/modules/test/browser/browser_BrowserWindowTracker.js
    45 - [e10s] browser/components/extensions/test/browser/browser_ext_urlbar_contextual_tip.js

[1] https://hg.mozilla.org/mozilla-central/annotate/a3a081ae714f1123bdc23c9d9ef53dfaa783a8de/layout/base/nsLayoutUtils.cpp#l767

Looks like kats added this warning in bug 1001438, with tnikkel as reviewer. kats seems to be away for the next few months, so I'll bug tnikkel...

Timothy, if that's not too far back into ancient history, do you recall how worrisome this warning is and do you know if it's worth keeping (and/or worth investigating why we get into this unexpected scenario so often)?

Here's a searchfox link, for reference:
https://searchfox.org/mozilla-central/rev/4218cb868d8deed13e902718ba2595d85e12b86b/layout/base/nsLayoutUtils.cpp#765

Depends on: 1001438
Flags: needinfo?(tnikkel)
Flags: needinfo?(tnikkel)
Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9bb8cf06af14
Don't get the display port in nsLayoutUtils::SetDisplayPortMargins when we don't need it because we don't have a frame. r=botond

I'm not sure if this fixes all instances, but from my sample it should fix a large proportion.

https://hg.mozilla.org/mozilla-central/rev/9bb8cf06af14

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.