158236 - Remove 'watchfordiffs' column from namedqueries table

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Bradley Baetz (:bbaetz)]

I son't know what its for; and 2.14 doesn't use it. Lets kill it.

Comment 1

[Bradley Baetz (:bbaetz)]

2.14 and later, that should be... 

Comment 2

[Bradley Baetz (:bbaetz)]

Attachment: v1

Also remove the 'not quite ready' comment on a non existant table which has
been there for years...

Comment 3

[J. Paul Reed [:preed]]

Comment on attachment 91899 [details] [diff] [review]
v1

Looks good to me; lord knows I love tight, efficient... databases.

r=preed

Comment 4

[Jouni Heikniemi]

Comment on attachment 91899 [details] [diff] [review]
v1

r=jouni

Comment 5

[Matthew Tuck [:CodeMachine]]

How about we find out what it was for?  It may well serve a good use and not
using it could be considered a bug.  It would be a shame to schema-remove
something we have use for.

Comment 6

[Bradley Baetz (:bbaetz)]

I can't find any cvs history which shows that it was ever used. Its of no
benefit, since nothing actually sets it. It doesn't even have a default value
set. I guess we could get myk/endico to do:

SELECT * FROM namedqueries WHERE watchfordiffs != 0

but I don't really see the point...

Comment 7

[Bradley Baetz (:bbaetz)]

Myk ran it, and no row on bmo has a non-0 column for that field, which means
that there isn't any usful data, and its highly unlikly that it was ever used.

Fix checked in.