Closed Bug 158236 Opened 19 years ago Closed 19 years ago

Remove 'watchfordiffs' column from namedqueries table

Categories

(Bugzilla :: Bugzilla-General, defect)

2.17
x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: bbaetz, Assigned: bbaetz)

Details

(Whiteboard: [schema])

Attachments

(1 file)

I son't know what its for; and 2.14 doesn't use it. Lets kill it.
2.14 and later, that should be... 
Status: NEW → ASSIGNED
Whiteboard: [schema]
Target Milestone: --- → Bugzilla 2.18
Attached patch v1Splinter Review
Also remove the 'not quite ready' comment on a non existant table which has
been there for years...
Comment on attachment 91899 [details] [diff] [review]
v1

Looks good to me; lord knows I love tight, efficient... databases.

r=preed
Attachment #91899 - Flags: review+
Comment on attachment 91899 [details] [diff] [review]
v1

r=jouni
Attachment #91899 - Flags: review+
How about we find out what it was for?  It may well serve a good use and not
using it could be considered a bug.  It would be a shame to schema-remove
something we have use for.
I can't find any cvs history which shows that it was ever used. Its of no
benefit, since nothing actually sets it. It doesn't even have a default value
set. I guess we could get myk/endico to do:

SELECT * FROM namedqueries WHERE watchfordiffs != 0

but I don't really see the point...
Myk ran it, and no row on bmo has a non-0 column for that field, which means
that there isn't any usful data, and its highly unlikly that it was ever used.

Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.