1582391 - Create a muted state for the PiP indicator icon in the tab

Status: RESOLVED INVALID

(Toolkit :: Toolbars and Toolbar Customization, enhancement)

Description

[Timea Cernea [:tbabos][inactive]]

Affected versions:
Nightly 71.0a1 (2019-09-18)
Beta 70.0b7

Affected platforms:
Windows 7/10

Steps to reproduce:

• Launch Nightly and Beta
• Go to any video hosting sites, such as youtube
• Play a video and toggle it in the PiP window
• Mute the video by clicking on the PiP indicator icon from the tab

Expected result:
The PiP indicator icon should change to a muted version, as it can be observed for the "Mute tab" icon.

Actual Result:
PiP indicator icon remains the same, the user has to actually listen to the sound in order to know if it's muted or not.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Hey JSON_Voorhees, was this an intentional choice, to have the PiP indicator override the tab muted state?

Comment 2

[Dave Justice]

I thought I answered this, sorry.

It was intentional, we talked about showing the audio indicator icon on hover, so that users could still mute the tab it if was pinned.

Comment 3

[Cristian Craciun]

Build ID 20191122091512
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:72.0) Gecko/20100101 Firefox/72.0

This issue is also reproducible on Nightly 72 on macOS.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

This should be fixed by bug 1612648.

Comment 5

[alex_mayorga]

Attachment: Mute indicator obscures the favicon

¡Hola y'all!

Just noticed that the mute indicator obscures the favicon.

Should this be a separate bug or is this one it?

Alice0775 suggested this userChrome.css over at http://forums.mozillazine.org/viewtopic.php?p=14873976#p14873976 :

.tab-icon-sound[pictureinpicture][muted] {
fill: #aaaaaa !important;
}

PiP is getting really pretty lately. Thanks y'all for the continued work on it.

¡Gracias!
Alex

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Hi alex_mayorga,

This is intentional behaviour - when using PiP, we want to make it more obvious how to mute the whole tab, so we're re-using the favicon overlay toggle from when the tab is pinned.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

The Proton interface changed things dramatically, and now we show a "Picture-in-Picture" label under the page title when there's a video in PiP. I think we can close this one out as INVALID now.