1582463 - [wpt-sync] Sync PR 19160 - Fix visibility additive composition test

Status: RESOLVED FIXED

(Core :: DOM: Animation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 19160 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19160
Details from upstream follow.

Stephen McGruer <[e-mail]> wrote:

Fix visibility additive composition test

https://drafts.csswg.org/web-animations-1/#animating-visibility does not define additive composition behavior for visibility, so the default replace behavior holds and therefore 'visible' + 'hidden' = 'hidden' I know (where the former is the underlying style).

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=29d4ceb44cf4ac1ecac8a2d33a30f6701838da5f

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f20279cf75e691defd96266222dcdc08ba1c9207

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 3 tests and 2008[windows7-32-debug,windows7-32-opt], 2033[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt] subtests
OK     : 3
PASS   : 2005[windows7-32-debug,windows7-32-opt], 2030[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt]
FAIL   : 3

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/web-animations/animation-model/animation-types/accumulation-per-property.html
    visibility: onto "visible": FAIL
/web-animations/animation-model/animation-types/addition-per-property.html
    visibility: onto "visible": FAIL

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e22a914b5df2
[wpt PR 19160] - Fix visibility additive composition test, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/a88c24103f2d
[wpt PR 19160] - Update wpt metadata, a=testonly

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/e22a914b5df2
https://hg.mozilla.org/mozilla-central/rev/a88c24103f2d