1582518 - Add an IsEmpty() method to IntervalSet

Status: RESOLVED FIXED

(Core :: Audio/Video, enhancement, P3)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Having a method to check if an IntervalSet is empty would be a QoL improvement: it's more concise and readable than checking the same thing via Length().

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1582518 - Add an IsEmpty() method to media's IntervalSet. r?dminor

This is a quality of life improvement:

• More concise than checking if Length() == 0.
• More readable then if(mySet.Length()) (in my opinion).
• We already have checks that test if IntervalSets are empty by looking at their
  length, so there is a use case for this.

Comment 2

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1582518 - Restyle some of media's Intervals.h. r?dminor

Restyle include guard + includes to conform to new style rules.

Depends on D46637

Comment 3

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1582518 - Replace IntervalSet.Length usages with IsEmpty where appropriate. r?dminor

This replaces the instances where Length was being called on an interval set
to determine if it was empty or not empty. IsEmpty makes the intention in these
cases more immediately obvious, and avoids the need to think about ints as
bools in cases like if(!mySet.Length()).

Depends on D46638

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1815141a8caa
Add an IsEmpty() method to media's IntervalSet. r=dminor
https://hg.mozilla.org/integration/autoland/rev/63b0cd12e313
Restyle some of media's Intervals.h. r=dminor
https://hg.mozilla.org/integration/autoland/rev/8cbbfc9b3fb3
Replace IntervalSet.Length usages with IsEmpty where appropriate. r=dminor

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/1815141a8caa
https://hg.mozilla.org/mozilla-central/rev/63b0cd12e313
https://hg.mozilla.org/mozilla-central/rev/8cbbfc9b3fb3