1582523 - Update mochitests which depend on cross-process frame load events

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task)

Description

[Kris Maglione [:kmag]]

Several mochitests have hacks to make a few trips through the event loop to wait for remote subframes to load before proceeding, and several others are skipped because they generally timeout when they run before their remote subframes are fully loaded.

The former are all marked with comments, and are easy to update. The latter, alas, are generally not so obvious. I'm going to re-enable the ones that we already have notes about here, but the others are probably just going to require a bunch of manual re-testing to find.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1582523: Part 1 - Actually block document load event during OOP frame loads. r=nika

This fixes both our failure to register load blockers for remote frames and
our failure to keep the load event blocked during frameloader rebuilding on
remoteness change.

Comment 2

[Kris Maglione [:kmag]]

Attachment: Bug 1582523: Part 2 - Update tests which rely on OOP frames blocking load. r=nika

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6c10aa450ba
Part 1 - Actually block document load event during OOP frame loads. r=nika
https://hg.mozilla.org/integration/autoland/rev/72ca7d054061
Part 2 - Update tests which rely on OOP frames blocking load. r=nika

Comment 4

[Andreea Pavel [:apavel]]

Backed out for build bustages at ContentChild.cpp

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=72ca7d0540618e415429186af9deaa719d7c308f&selectedJob=267587531

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=267587531&repo=autoland&lineNumber=33725

Backout: https://hg.mozilla.org/integration/autoland/rev/05604efe0f918eb2abe4efcc7d47570c46441c36

Comment 5

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/be9eb34c76d6b670eaf0028558828ff0748c85f7
Bug 1582523: Part 1 - Actually block document load event during OOP frame loads. r=nika

https://hg.mozilla.org/integration/mozilla-inbound/rev/64a6c93fd556796d4a311bebf1d05462dc1e3c2c
Bug 1582523: Part 2 - Update tests which rely on OOP frames blocking load. r=nika

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/be9eb34c76d6
https://hg.mozilla.org/mozilla-central/rev/64a6c93fd556