Closed Bug 1582523 Opened 5 months ago Closed 5 months ago

Update mochitests which depend on cross-process frame load events

Categories

(Core :: DOM: Navigation, task)

task
Not set

Tracking

()

RESOLVED FIXED
mozilla71
Fission Milestone M4
Tracking Status
firefox71 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Several mochitests have hacks to make a few trips through the event loop to wait for remote subframes to load before proceeding, and several others are skipped because they generally timeout when they run before their remote subframes are fully loaded.

The former are all marked with comments, and are easy to update. The latter, alas, are generally not so obvious. I'm going to re-enable the ones that we already have notes about here, but the others are probably just going to require a bunch of manual re-testing to find.

This fixes both our failure to register load blockers for remote frames and
our failure to keep the load event blocked during frameloader rebuilding on
remoteness change.

Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a6c10aa450ba
Part 1 - Actually block document load event during OOP frame loads. r=nika
https://hg.mozilla.org/integration/autoland/rev/72ca7d054061
Part 2 - Update tests which rely on OOP frames blocking load. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/be9eb34c76d6b670eaf0028558828ff0748c85f7
Bug 1582523: Part 1 - Actually block document load event during OOP frame loads. r=nika

https://hg.mozilla.org/integration/mozilla-inbound/rev/64a6c93fd556796d4a311bebf1d05462dc1e3c2c
Bug 1582523: Part 2 - Update tests which rely on OOP frames blocking load. r=nika
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Flags: needinfo?(kmaglione+bmo)
Regressions: 1582948
You need to log in before you can comment on or make changes to this bug.