1582562 - remove all references to geckoview_example.test

Status: RESOLVED FIXED

(GeckoView :: General, task, P3)

Description

[[ex-Mozilla] Agi Sferro | :agi]

The geckoview_example project somehow has a test package, even though we don't use it. We should get rid of it to avoid confusion.

e.g. geckoview_example:installWithGeckoBinariesDebugAndroidTest is defined.

Comment 1

[Nick Alexander :nalexander [he/him]]

(In reply to :Agi | ⏰ PST | he/him from comment #0)

The geckoview_example project somehow has a test package, even though we don't use it. We should get rid of it to avoid confusion.

e.g. geckoview_example:installWithGeckoBinariesDebugAndroidTest is defined.

I'm not sure this is possible. We need to ensure that we don't accidentally build or install it, but I'm not sure we can actually get rid of it. A quick read suggests we can't stop building this.

I don't know how Jesup got it installed; probably a ./mach gradle installWithGeckoBinariesDebugAndroidTest or similar. (Note: no project restriction.)

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

Yeah I guess removing all references to it should be enough.

I think this is just a typo then: https://searchfox.org/mozilla-central/rev/7531325c8660cfa61bf71725f83501028178cbb9/mobile/android/gradle.configure#359

Comment 3

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1582562 - Do not build/install geckoview_example.test.

We don't use it and causes confusion when mach install fails because the
signature of geckoview_example.test doesn't match.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8fe985b593db
Do not build/install geckoview_example.test. r=nalexander,owlish

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/8fe985b593db