1582639 - TypeError: controller is null searchbar.js:944:11 , "Clear Search History" stops working

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[Alice0775 White]

[Tracking Requested - why for this release]:

Reproducible: always

Steps To Reproduce:

1. Enable SearchBar
2. Enter something search word and Hit Enter
3. Right click on the SearchBar
4. Choose "Clear Search History"

Actual Results:
Nothing happens.
Error in Browser console:
TypeError: controller is null searchbar.js:944:11
_buildContextMenu chrome://browser/content/search/searchbar.js:944

Expected Results:
Search History should be deleted. No error in Browser Console.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a4bfd6e22c412a65d558d46c6a3f19da14a03a85&tochange=9ec431469e3777c3c9675e7699a38e3155ada5dd

Regressed by: 9ec431469e3777c3c9675e7699a38e3155ada5dd Tim Nguyen — Bug 1534455 - Convert autocomplete binding to a customized input element. r=dao,bgrins

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1582639 - Fix 'Clear Search History' menu item and clean up related code. r=bgrins

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b510b386edff
Fix 'Clear Search History' menu item and clean up related code. r=bgrins

Comment 3

[Tim Nguyen :ntim]

Attachment: Bug 1582639 - Fix browser_426329.js and browser_940307_panel_click_closure_handling.js failures.

Comment 4

[Oana Pop-Rus]

Backed out for bc failures in browser/components/search/test/browser/browser_426329.js

Push with failure:https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=superseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=b510b386edff4099cffbeeb7b5186fb8a908236e&selectedJob=267757523

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=267757523&repo=autoland&lineNumber=4716

Backout: https://hg.mozilla.org/integration/autoland/rev/dd9e77cbe7e770970d13fbdeffb77c6c7e7ea4f1

Comment 5

[Oana Pop-Rus]

This also perma fails in browser_940307_panel_click_closure_handling.js

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=success%2Csuperseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=windows%2C10%2Cx64%2Cquantumrender%2Cdebug%2Cmochitests%2Ctest-windows10-64-qr%2Fdebug-mochitest-browser-chrome-e10s-5%2Cm%28bc5%29&fromchange=b295a3c77fb1e03874d675d074b7441cb1ef5c7a&tochange=dd9e77cbe7e770970d13fbdeffb77c6c7e7ea4f1&selectedJob=267756766

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=267756766&repo=autoland&lineNumber=17840

[task 2019-09-20T22:41:24.916Z] 22:41:24 INFO - TEST-START | browser/components/customizableui/test/browser_940307_panel_click_closure_handling.js
[task 2019-09-20T22:41:25.330Z] 22:41:25 INFO - GECKO(10320) | --DOMWINDOW == 10 (0000020846070000) [pid = 8212] [serial = 33] [outer = 0000000000000000] [url = about:blank]
[task 2019-09-20T22:41:25.330Z] 22:41:25 INFO - GECKO(10320) | --DOMWINDOW == 9 (000002084606E800) [pid = 8212] [serial = 39] [outer = 0000000000000000] [url = about:blank]
[task 2019-09-20T22:41:25.330Z] 22:41:25 INFO - GECKO(10320) | --DOMWINDOW == 8 (00000208401AC000) [pid = 8212] [serial = 35] [outer = 0000000000000000] [url = about:blank]
[task 2019-09-20T22:41:25.330Z] 22:41:25 INFO - GECKO(10320) | --DOCSHELL 000002084014E000 == 2 [pid = 8212] [id = {083f565e-d529-4719-9ae0-81fd3042fb77}] [url = about:blank]
[task 2019-09-20T22:41:25.330Z] 22:41:25 INFO - GECKO(10320) | --DOCSHELL 00000208465D7000 == 1 [pid = 8212] [id = {aa7a5011-f2e6-444f-8717-091d860662d8}] [url = about:blank]
[task 2019-09-20T22:41:25.430Z] 22:41:25 INFO - GECKO(10320) | --DOMWINDOW == 7 (0000020840112B60) [pid = 8212] [serial = 38] [outer = 0000000000000000] [url = about:home]
[task 2019-09-20T22:41:25.430Z] 22:41:25 INFO - GECKO(10320) | --DOCSHELL 000002084015A000 == 0 [pid = 8212] [id = {84c8ab3f-0a2a-4794-8d52-b3c3845a66c9}] [url = about:mozilla]
[task 2019-09-20T22:41:25.430Z] 22:41:25 INFO - GECKO(10320) | --DOMWINDOW == 6 (0000020840112980) [pid = 8212] [serial = 36] [outer = 0000000000000000] [url = about:blank]
[task 2019-09-20T22:41:25.777Z] 22:41:25 INFO - TEST-INFO | started process screenshot
[task 2019-09-20T22:41:25.861Z] 22:41:25 INFO - TEST-INFO | screenshot: exit 0
[task 2019-09-20T22:41:25.861Z] 22:41:25 INFO - Buffered messages logged at 22:41:24
[task 2019-09-20T22:41:25.861Z] 22:41:25 INFO - Entering test bound plain_button
[task 2019-09-20T22:41:25.861Z] 22:41:25 INFO - Buffered messages logged at 22:41:25
[task 2019-09-20T22:41:25.862Z] 22:41:25 INFO - Waiting for overflow button to have non-0 size
[task 2019-09-20T22:41:25.862Z] 22:41:25 INFO - Leaving test bound plain_button
[task 2019-09-20T22:41:25.862Z] 22:41:25 INFO - Entering test bound searchbar_in_panel
[task 2019-09-20T22:41:25.862Z] 22:41:25 INFO - Waiting for overflow button to have non-0 size
[task 2019-09-20T22:41:25.862Z] 22:41:25 INFO - TEST-PASS | browser/components/customizableui/test/browser_940307_panel_click_closure_handling.js | Panel should still be open -
[task 2019-09-20T22:41:25.862Z] 22:41:25 INFO - Buffered messages finished
[task 2019-09-20T22:41:25.862Z] 22:41:25 INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_940307_panel_click_closure_handling.js | Uncaught exception - at chrome://mochikit/content/tests/SimpleTest/EventUtils.js:508 - TypeError: aTarget is null
[task 2019-09-20T22:41:25.862Z] 22:41:25 INFO - Stack trace:
[task 2019-09-20T22:41:25.863Z] 22:41:25 INFO - synthesizeMouseAtCenter@chrome://mochikit/content/tests/SimpleTest/EventUtils.js:508:14
[task 2019-09-20T22:41:25.863Z] 22:41:25 INFO - searchbar_in_panel@chrome://mochitests/content/browser/browser/components/customizableui/test/browser_940307_panel_click_closure_handling.js:78:14
[task 2019-09-20T22:41:25.863Z] 22:41:25 INFO - AsyncTester_execTest/<@chrome://mochikit/content/browser-test.js:1350:34
[task 2019-09-20T22:41:25.863Z] 22:41:25 INFO - asyncTester_execTest@chrome://mochikit/content/browser-test.js:1385:11
[task 2019-09-20T22:41:25.863Z] 22:41:25 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1213:14
[task 2019-09-20T22:41:25.863Z] 22:41:25 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:805:67
[task 2019-09-20T22:41:25.863Z] 22:41:25 INFO - Leaving test bound searchbar_in_panel
[task 2019-09-20T22:41:25.863Z] 22:41:25 INFO - Entering test bound disabled_button_in_panel
[task 2019-09-20T22:41:25.902Z] 22:41:25 INFO - Waiting for overflow button to have non-0 size

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d6c747a780c
Fix 'Clear Search History' menu item and clean up related code. r=bgrins

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6381b3df12ca
Fix browser_426329.js and browser_940307_panel_click_closure_handling.js failures.

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/5d6c747a780c
https://hg.mozilla.org/mozilla-central/rev/6381b3df12ca

Comment 9

[Intermittent Failures Robot]

2 failures in 4350 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 2

Platform breakdown:

• windows10-64-qr: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1582639&startday=2019-09-16&endday=2019-09-22&tree=all

Comment 10

[Marcela (Please NI request to Brindusa Tot)]

Verified fixed on Nightly Version 73.0a1 Build ID 20191205094649, Beta 72.0b2 Build ID 20191203141951, Release 71.0 Build ID 20191202093317 on Windows 10, macOS 10.14 and Ubuntu 18.04