Closed Bug 1582646 Opened 5 years ago Closed 5 years ago

Crash in [@ mozilla::net::WebrtcTCPSocket::InvokeOnConnected]

Categories

(Core :: WebRTC: Networking, defect, P2)

71 Branch
Unspecified
Windows 10
defect

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox69 --- unaffected
firefox70 --- unaffected
firefox71 + fixed

People

(Reporter: pascalc, Assigned: bwc)

References

(Regression)

Details

(Keywords: crash, regression)

Crash Data

Attachments

(1 file)

This bug is for crash report bp-0f023cf2-bd78-4b75-87fd-80e630190919.

Top 10 frames of crashing thread:

0 xul.dll void mozilla::net::WebrtcTCPSocket::InvokeOnConnected media/mtransport/ipc/WebrtcTCPSocket.cpp:449
1 xul.dll nsresult mozilla::net::WebrtcTCPSocket::OpenWithoutHttpProxy media/mtransport/ipc/WebrtcTCPSocket.cpp:324
2 xul.dll nsresult mozilla::net::WebrtcTCPSocket::OnProxyAvailable media/mtransport/ipc/WebrtcTCPSocket.cpp
3 xul.dll static nsresult mozilla::net::nsAsyncResolveRequest::DoCallback::<unnamed-tag>::operator netwerk/base/nsProtocolProxyService.cpp:366
4 xul.dll xul.dll@0xac6995 
5 xul.dll nsresult mozilla::net::nsAsyncResolveRequest::AsyncApplyFilters::Finish netwerk/base/nsProtocolProxyService.cpp:599
6 xul.dll nsresult mozilla::net::nsAsyncResolveRequest::AsyncApplyFilters::ProcessNextFilter netwerk/base/nsProtocolProxyService.cpp:509
7 xul.dll nsresult mozilla::net::nsAsyncResolveRequest::AsyncApplyFilters::AsyncProcess netwerk/base/nsProtocolProxyService.cpp:485
8 xul.dll void mozilla::net::nsAsyncResolveRequest::DoCallback netwerk/base/nsProtocolProxyService.cpp:375
9 xul.dll nsresult mozilla::net::ExecuteCallback::Run netwerk/base/nsPACMan.cpp:119

Calixte, any idea what patch could have regressed this? Thanks

Flags: needinfo?(cdenizet)

These started in the 20190918215055 nightly build, on windows.

Keywords: regression
Version: unspecified → 71 Branch
Priority: -- → P2

Looks like a nullptr crash, I'll look at it.

Assignee: nobody → docfaraday
Flags: needinfo?(cdenizet)

Ok, I see what's wrong. Fixing.

Regressed by: 1569183

Also, since OnProxyAvailable always happens on main regardless of the target we
set, don't bother setting the target.

Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/81ab3774184b Cancel proxy lookup when socket closes. r=mjf
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: