1582663 - Maybe we should split nsHttpConnection

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P1)

Description

[Dragana Damjanovic [:dragana]]

Maybe we should split nsHttpConnection into a base class and separate Http < 2, Http2, Http3, etc.

Comment 1

[Kershaw Chang [:kershaw]]

I'll start thinking about how to do this.

Comment 2

[Dragana Damjanovic [:dragana]]

Attachment: Bug 1582663 - Remove static_cast for nsHttpConnection. r=valentin,mayhemer

Comment 3

[Dragana Damjanovic [:dragana]]

Attachment: Bug 1582663 - Split nsHttpConnection into HttpConnectionBase and nsHttpConnection. Make nsHttpConnectionMgr use only HttpConnectionBase. r=valentin,mayhemer

Depends on D64033

Comment 4

[Dragana Damjanovic [:dragana]]

Attachment: Bug 1582663 - Add HttpConnectionUDP. It is just a copy of nsHttpConnection. r=valentin,mayhemer

Depends on D64035

Comment 5

[Dragana Damjanovic [:dragana]]

Attachment: Bug 1582663 - Remove Http3Session from nsHttpConnection. r=valentin,mayhemer

Depends on D64037

Comment 6

[Dragana Damjanovic [:dragana]]

Attachment: Bug 1582663 - nsHttpConnectionMgr's idle connections can only be TCP connections, no Http3 connections. r=valentin,mayhemer

Depends on D64038

Comment 7

[Dragana Damjanovic [:dragana]]

Attachment: Bug 1582663 - Remove functions from HttpConnectionBase that are TCP connection specific. r=valentin,mayhemer

Depends on D64039

Comment 8

[Dragana Damjanovic [:dragana]]

Attachment: Bug 1582663 - Remove what is not needed from HttpConnectionUDP. r=valentin,mayhemer

Depends on D64041

Comment 9

[Dragana Damjanovic [:dragana]]

Attachment: Bug 1582663 - Remove white space. r=valentin,mayhemer

Comment 10

[Dragana Damjanovic [:dragana]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=56886db8693a122b30db9fd936caca77d94033cc

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c3b5457f7d9
Remove static_cast for nsHttpConnection. r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/24db57a7ef45
Split nsHttpConnection into HttpConnectionBase and nsHttpConnection. Make nsHttpConnectionMgr use only HttpConnectionBase. r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/5fcf7de9bfd3
Add HttpConnectionUDP. It is just a copy of nsHttpConnection. r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/c3bc78c00cd2
Remove Http3Session from nsHttpConnection. r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/b08f1feace14
nsHttpConnectionMgr's idle connections can only be TCP connections, no Http3 connections. r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/51cbcc43940a
Remove functions from HttpConnectionBase that are TCP connection specific. r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/58e785ec0532
Remove what is not needed from HttpConnectionUDP. r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/2de1aef115ee
Remove white space. r=mayhemer

Comment 12

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/5c3b5457f7d9
https://hg.mozilla.org/mozilla-central/rev/24db57a7ef45
https://hg.mozilla.org/mozilla-central/rev/5fcf7de9bfd3
https://hg.mozilla.org/mozilla-central/rev/c3bc78c00cd2
https://hg.mozilla.org/mozilla-central/rev/b08f1feace14
https://hg.mozilla.org/mozilla-central/rev/51cbcc43940a
https://hg.mozilla.org/mozilla-central/rev/58e785ec0532
https://hg.mozilla.org/mozilla-central/rev/2de1aef115ee