1582702 - Polish Search highlighting

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: image.png

This is a follow up for bug 1580030

We should unify search highlighting between the Network and Debugger panels.
A screenshot showing the current state attached.

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

WDYT?

Comment 2

[:Harald Kirschner :digitarald]

Attachment: Inspector rules example

Comment 3

[:Harald Kirschner :digitarald]

UX Bug: https://github.com/firefox-devtools/ux/issues/96

Comment 4

[lloan alas:[lloanalas]]

Are we going to replicate the look of the debugger panel (which I think is what we had before) or are we leaving it as is (different)?

Or are we making it look like the rules panel? And if so, are we only highlighting it or are we also changing the colors of the key: value to reflect those seen there?

Thanks!

Comment 5

[:Harald Kirschner :digitarald]

If I had to pick between the 2, I'd prefer the subtler yellow of the Inspector. Let's make a call for this in https://github.com/firefox-devtools/ux/issues/96 .

Comment 6

[lloan alas:[lloanalas]]

Attachment: Bug 1582702 - Polish Search highlighting colors. r=fvsch

Comment 7

[Florens Verschelde :fvsch]

UI spec is in this comment:
https://github.com/firefox-devtools/ux/issues/14#issuecomment-537047482

Comment 8

[lloan alas:[lloanalas]]

patch updated

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d579d78f3727
Polish Search highlighting colors. r=fvsch

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d579d78f3727