1582734 - debugger: CmdOrCtrl shown in menu shortcuts instead of Ctrl

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[David Balažic]

Attachment: Screenshot

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

F12 / Debugger, open a JS file, right click a line (see screenshot)

Actual results:

The shortcut in the menu say CmdOrCtrl+B

Expected results:

The shortcut in the menu should say Ctrl+B on systems that have Ctrl keys and have no Cmd keys (and vice versa)

Like the hamburger menu does.

PS: Checked on nightly 71.0a1 (2019-09-19) (64-bit) - same as reported.

Comment 1

[David Balažic]

PPS: My Firefox is version 69.0.1 , even if the user agent string in the report says 69.0

Comment 2

[Virginia (please send need info request to Brindusa Tot)]

Hi David,

Thanks for reporting this bug to us.

I was able to reproduce it on Firefox Release 69.0.1 (64-bit), Firefox Beta 70.0b9 (64-bit) and Nightly 71.0a1 (2019-09-24) (64-bit) using Windows 7 and Windows 10.

I'll add a product and component so the corresponding dev team can take a look at it, but feel free to change it for a more appropriate one.

Regards,

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the report!

I can reproduce this on my machine (reproducible on Win as well as MacOS)

Might be also problem with the basic Context menu API (not necessarily Debugger issue).

Honza

Comment 4

[David Walsh :davidwalsh]

We're using formatKeyShortcut to replace stuff like CommandOrControl on Windows and Mac...but we're never passing CommandOrControl into that function -- only the letter of the accelerator (i.e. "b"). The modifiers are being added elsewhere which is why the symbols aren't properly displaying.

Comment 5

[David Walsh :davidwalsh]

Attachment: Bug 1582734 - Fix context menu accelerator text r=jlast

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/864c928edc5b
Fix context menu accelerator text r=jlast

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/864c928edc5b