1582763 - [Protections Panel] Remove blue badge from shield and toogle when Tracking Protection is off

Status: VERIFIED FIXED

(Firefox :: Site Identity, task, P1)

Description

[Eric Pang [:epang] UX]

Attachment: badge on shield and toggle.png

Remove the blue badge on the shield and toggle when Tracking Protection is turned off. The crossed-out shield is a strong enough indicator of the state.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1582763 - [Protections Panel] Remove blue badge from shield and toggle when TP is disabled.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7557fa807f7a
[Protections Panel] Remove blue badge from shield and toggle when TP is disabled. r=johannh

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 9094229 [details]
Bug 1582763 - [Protections Panel] Remove blue badge from shield and toggle when TP is disabled.

Beta/Release Uplift Approval Request

• User impact if declined: Confusing/annoying blue notification-dot on the shield icon that cannot be cleared when TP is disabled for a site.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce: Super simple - in the protections panel, toggle the tracking protection switch OFF for a site. Without the patch, a persistent blue dot is shown on top of the shield icon. With the patch, it is no longer present.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Mostly CSS removal, one tiny piece of code also removed. Very low risk.
• String changes made/needed: None

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/7557fa807f7a

Comment 5

[chsiang]

that's fast. thank you, nihanth!

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

The patch looks safe but given that it just landed and has no automatic tests, I'd like to have QA verify the fix on Nightly before evaluating it for uplifting.

Comment 7

[Ciprian Georgiu, Desktop QA]

Verified as fixed on latest Nightly 71.0a1 (2019-09-22), under macOS 10.13, Ubuntu 18.04 x64 and Windows 10 x64. The blue badge is not displayed anymore while TP is OFF, in privacy panel.

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9094229 [details]
Bug 1582763 - [Protections Panel] Remove blue badge from shield and toggle when TP is disabled.

Fix for skyline issue, verified in Nightly, let's uplift for beta 10.

Comment 9

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/releases/mozilla-beta/rev/69a1bd552648

Comment 10

[Oana Botisan, Desktop QA]

I verified the fix on Firefox 70.0b9 on Windows 10 x64, macOS 10.13 and Ubuntu 18.04 x64. The bug is not reproducing anymore.