1582856 - extension prefs are not reset to default properly

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P1)

Description

[Shane Caraveo (:mixedpuppy)]

https://support.mozilla.org/en-US/questions/1243033
https://twitter.com/g33klaura/status/1175047611222544389

ExtensionPreferencesManager stores the "original" pref value without differentiating default prefs from user set prefs. When all extensions are disabled or uninstalled, the "original" value is restored.

Firefox V.A: default value is 0
Extension takes control, sets value to 4, stores original value 0
Firefox V.B: changes default value to 1
Extension is uninstalled,

Expected:
pref value is reset, resulting in a value 1

Actual:
pref value is set to 0

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1582856 do not store default pref values in extension settings

Add a way to update the initialValue from any system using
the ExtensionSettingsStore. This is used to prevent storing default
pref values in the ExtensionPreferencesManager.

Comment 2

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cde908f033657b854f44a113cc27d636babc0bac

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c67d443836ab
do not store default pref values in extension settings r=robwu

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/c67d443836ab

Comment 5

[Alex Cornestean]

Hello,

Will this fix require manual validation? If yes, please provide some steps to reproduce in order to correctly test it and also, please set the "qe-verify+" flag. Otherwise, could the "qe-verify-" flag be added? Thanks!

Comment 6

[Shane Caraveo (:mixedpuppy)]

it's covered by unit tests