Closed Bug 1582976 Opened 5 months ago Closed 5 months ago

Use version_display.txt in SeaMonkey

Categories

(SeaMonkey :: Build Config, enhancement)

enhancement
Not set

Tracking

(seamonkey2.49esr wontfix, seamonkey2.53 affected, seamonkey2.57esr fixed, seamonkey2.63 wontfix)

RESOLVED FIXED
seamonkey2.68
Tracking Status
seamonkey2.49esr --- wontfix
seamonkey2.53 --- affected
seamonkey2.57esr --- fixed
seamonkey2.63 --- wontfix

People

(Reporter: frg, Assigned: frg)

References

Details

Attachments

(3 files, 1 obsolete file)

We are using only version.txt currently which makes it impossible to add version specific information whithout altering the ua.

Attached patch 1582976-versiondisplay.patch (obsolete) — Splinter Review

Let me know what you think about it.

Attachment #9094408 - Flags: feedback?(iann_bugzilla)
Comment on attachment 9094408 [details] [diff] [review]
1582976-versiondisplay.patch

Review of attachment 9094408 [details] [diff] [review]:
-----------------------------------------------------------------

Seems okay to me
Attachment #9094408 - Flags: feedback?(iann_bugzilla) → feedback+
Blocks: 1584803

Patch for comm-central.

Check for version_display.txt is already in suite/moz.configure.

Attachment #9094408 - Attachment is obsolete: true
Attachment #9097200 - Flags: review?(iann_bugzilla)

2.57 version

Attachment #9097201 - Flags: approval-comm-esr60?

2.53.1 version

Attachment #9097202 - Flags: approval-comm-release?
Comment on attachment 9097200 [details] [diff] [review]
1582976-versiondisplay-cc.patch

r=me
Attachment #9097200 - Flags: review?(iann_bugzilla) → review+
Comment on attachment 9097201 [details] [diff] [review]
1582976-versiondisplay-257.patch

r/a=me
Attachment #9097201 - Flags: review+
Attachment #9097201 - Flags: approval-comm-esr60?
Attachment #9097201 - Flags: approval-comm-esr60+
Comment on attachment 9097202 [details] [diff] [review]
1582976-versiondisplay-2531.patch

[Triage Comment]
r/a=me
Attachment #9097202 - Flags: review+
Attachment #9097202 - Flags: approval-comm-release?
Attachment #9097202 - Flags: approval-comm-release+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/8cb2fc11db8b
Use version_display.txt in SeaMonkey about page. r=IanN

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED

Patrick,

could you add the new suite/config/version_display.txt to the procedure for merge day changes. Same procedure as for TB I think.
If you need it in the comm-beta and comm-release tree now let me know and I will push the change to all of them.

Flags: needinfo?(clokep)

(In reply to Frank-Rainer Grahl (:frg) from comment #11)

Patrick,

could you add the new suite/config/version_display.txt to the procedure for merge day changes. Same procedure as for TB I think.
If you need it in the comm-beta and comm-release tree now let me know and I will push the change to all of them.

Done: https://hg.mozilla.org/users/bugzilla_standard8.plus.com/drivertools/rev/dd8da8b3f9078b145816a23a75e609ae174bd908

This follows the same guidelines as Thunderbird, so for example during the next merge:

  • c-c -> c-b: version goes from 2.68a1 to 2.68; version_display goes from 2.68a1 to 2.68b1
  • c-b -> c-r: version_display goes from 2.68b1 to 2.68
  • c-c version bump: version goes from 2.68a1 to 2.69a1; version_display gets overwritten to 2.69a1

Hope that makes sense! It is easy to tweak in the future if necessary!

Flags: needinfo?(clokep)
Comment on attachment 9097200 [details] [diff] [review]
1582976-versiondisplay-cc.patch

Thanks Patrick this is fine. Pushed to beta and release so it does not break. Seems only to be needed on beta but better safe than sorry.

https://hg.mozilla.org/releases/comm-release/rev/f9f5981ef6cea7d98757624c384d8bf08b1fb227
https://hg.mozilla.org/releases/comm-beta/rev/a737934eee3752699321b3b010a61ceefd4f0b6d
Attachment #9097200 - Flags: approval-comm-beta+

I just wanted to note that we went through merges today with these changes. I verified the best that I could that nothing crazy happened, but please let me know if something unwanted happened (or if something was missing)!

Some commits of note:

The new comm-beta files are fine. Maybe because the previous version_display.txt in beta missed the b1. Thanks for checking it and no big deal. Will monitor it the next time.

You need to log in before you can comment on or make changes to this bug.