1583041 - Xlib headers overriding member name

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Ian Neal]

Newer version of Xlib headers override our member name in gfx/layers/LayerScope.cpp
Fixes issue with conflict of Status variable between logging.h and Xlib.h
See https://github.com/protocolbuffers/protobuf/issues/4186

Comment 1

[Ian Neal]

Attachment: 1583041-xlib_logging_hack.patch

Test on 2.53
On m-c was landed in https://hg.mozilla.org/mozilla-central/rev/f07a1e9cbab30755c76e3c1334b7d78aee1fb4e3 as part of Bug 1478815 part 7 - Add a buffer unrotate operation to DrawTarget
Do we just take this patch or backport bug 1478815 and dependencies?

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9101672 [details] [diff] [review]
1583041-xlib_logging_hack.patch

Looking at the bug we would need to backport too much. Lets take it into our branches for 2.53 and 2.57 for now.

Comment 3

[Frank-Rainer Grahl (:frg)]

Fixed in 2.53.1