Closed
Bug 1583041
Opened 5 years ago
Closed 4 years ago
Xlib headers overriding member name
Categories
(SeaMonkey :: Build Config, defect)
SeaMonkey
Build Config
Tracking
(seamonkey2.53+ fixed, seamonkey2.57esr? affected, seamonkey2.63 wontfix)
RESOLVED
FIXED
seamonkey2.53
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
Attachments
(1 file)
|
983 bytes,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
Newer version of Xlib headers override our member name in gfx/layers/LayerScope.cpp
Fixes issue with conflict of Status variable between logging.h and Xlib.h
See https://github.com/protocolbuffers/protobuf/issues/4186
Test on 2.53
On m-c was landed in https://hg.mozilla.org/mozilla-central/rev/f07a1e9cbab30755c76e3c1334b7d78aee1fb4e3 as part of Bug 1478815 part 7 - Add a buffer unrotate operation to DrawTarget
Do we just take this patch or backport bug 1478815 and dependencies?
Attachment #9101672 -
Flags: review?(frgrahl)
Attachment #9101672 -
Flags: approval-comm-release?
Attachment #9101672 -
Flags: approval-comm-esr60?
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9101672 [details] [diff] [review]
1583041-xlib_logging_hack.patch
Looking at the bug we would need to backport too much. Lets take it into our branches for 2.53 and 2.57 for now.
Attachment #9101672 -
Flags: review?(frgrahl)
Attachment #9101672 -
Flags: review+
Attachment #9101672 -
Flags: approval-comm-release?
Attachment #9101672 -
Flags: approval-comm-release+
Attachment #9101672 -
Flags: approval-comm-esr60?
Attachment #9101672 -
Flags: approval-comm-esr60+
|
|
||
Updated•5 years ago
|
status-seamonkey2.53:
--- → affected
status-seamonkey2.57esr:
--- → affected
status-seamonkey2.63:
--- → wontfix
|
|
||
Comment 3•5 years ago
|
||
Fixed in 2.53.1
tracking-seamonkey2.57esr:
--- → ?
Target Milestone: --- → seamonkey2.53
|
|
||
Updated•4 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
tracking-seamonkey2.53:
--- → +
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•