Closed Bug 1583101 Opened 5 years ago Closed 5 years ago

calendar-alarm-dialog.xul - "dismiss for" doesn't work

Categories

(Calendar :: Dialogs, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: mkmelin, Unassigned)

Details

(Keywords: regression)

In the calendar-alarm-dialog, try to dismiss an event for, say 3 mins. Can't do it.

JavaScript error: chrome://calendar/content/calendar-alarm-dialog.xul, line 1: ReferenceError: updateUIText is not defined
JavaScript error: chrome://calendar/content/widgets/calendar-alarm-widget.js, line 323: TypeError: eventTarget is null

Patch for bug 1519330 applied, so lines may be somewhat off.

Other things to adjust in this dialog.

  • Import PluralForm Services instead of declaring them global
  • adjust jsdoc, the type should be after. E.g. * @param event {Event} -> * @param {Event} event

Using Daily 71.0a1 (Build ID 20190920082822). When changing the value for the snooze input field I get the "ReferenceError: updateUIText is not defined" too. But the other error I don't see. Dismiss and Snooze work correctly, i.e. reminder is shown again after 1 minute, 3 minutes etc. Maybe the problem you see is caused by the patch?

You're right, I don't see "eventTarget is null" on trunk.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.