Closed Bug 1583138 Opened 1 year ago Closed 1 year ago

Prepare clang-tidy checkers for LLVM 9.0

Categories

(Firefox Build System :: Source Code Analysis, task)

task
Not set
normal

Tracking

(firefox71 fixed)

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: dmajor, Assigned: dmajor)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

47 bytes, text/x-phabricator-request
Details | Review
No description provided.

In clang 9, the signature of registerPPCallbacks changed and it no longer provides us a CompilerInstance [0]. I couldn't find a way to reach the CompilerInstance from the new structures, so I've inserted a level into the class hierarchy that mimics the old functionality.

With this patch, clang-tidy compiles with either clang-8 or clang-9, so we can land this independently in preparation for bug 1573211.

[0] For reference: the new signature was introduced in https://github.com/llvm/llvm-project/commit/bbc89dcb29035ad450ac0981b8f51a6cfa2aa8ba, the old overload was marked deprecated in https://github.com/llvm/llvm-project/commit/e9087fe75c8652a442bada0a7e02cba0df781074 and removed in https://github.com/llvm/llvm-project/commit/ee737a84d75b701c2ae3a8c9a0abbae63fc330af.

Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a96435a6dc54
Prepare clang-tidy for clang-9 r=andi
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Regressions: 1589096
You need to log in before you can comment on or make changes to this bug.