1583162 - Add an option in preferences to allow search suggestions in private windows

Status: VERIFIED FIXED

(Firefox :: Search, task, P2)

Description

[Mark Banner (:standard8)]

We want to add a new option in preferences to allow search suggestions in private windows.

We need to make sure both the search bar and address bar reflect the new option.

Comment 1

[Mark Banner (:standard8)]

We're also going to remove the "Show suggestions" option from the search bar context menu. This doesn't work correctly anyway as it may also stop & enable the suggestions for the main address bar.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1583162 - Remove 'Show Suggestions' from the search bar context menu as it doesn't work correctly, and using prefs UI is better. r?mak!

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1583162 - Add an option in preferences to allow search suggestions in private windows. r?mak!

Depends on D48971

Comment 4

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b807f9bafb361f7b5774d10785eac3b40cbb35c

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd04c04797d0
Remove 'Show Suggestions' from the search bar context menu as it doesn't work correctly, and using prefs UI is better. r=mak
https://hg.mozilla.org/integration/autoland/rev/71259d26450a
Add an option in preferences to allow search suggestions in private windows. r=mak,fluent-reviewers,flod

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/bd04c04797d0
https://hg.mozilla.org/mozilla-central/rev/71259d26450a

Comment 7

[Rares Doghi, Desktop QA]

This issue is Verified as fixed in our latest Release version 72.0.2, on Windows 10, Mac OsX 10.13 and Ubuntu 18.04.