1583269 - Update our in-tree ICU to 65

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, task)

Description

[André Bargull [:anba]]

A release candidate for ICU 65 was released on 2019-09-11. Also see http://site.icu-project.org/download/65.

Comment 1

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=223e622687bc75bd7d1a34416815793ca3be2025

New try with ICU patch to unbreak build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8602536c545cb537fc167863dc19d01ff398c2f0

Comment 2

[André Bargull [:anba]]

ICU 65 was released yesterday http://site.icu-project.org/download/65.

Setting bug 1570370 as a blocker, because updating ICU implies updating to a new CLDR, which means updating the language tag registry. And because the registry gets a major rewrite in bug 1570370, it makes sense to first land that bug to avoid merge conflicts.

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1583269 - Part 1: Remove custom patch to add thread-safety to icu::TimeZone::adoptDefault. r=jwalden!

The custom patch is no longer necessary now that https://unicode-org.atlassian.net/browse/ICU-20595
has been fixed. Also inline icu::TimeZone::recreateDefault into its sole caller and then remove
this API addition.

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1583269 - Part 2: Update in-tree ICU to release 65.1. r=jwalden!

Comment 6

[André Bargull [:anba]]

Attachment: Bug 1583269 - Part 3: Update tests after ICU update. r=jwalden!

js/src/tests/jstests.list

• Enable now passing test262 tests.

non262/Intl/RelativeTimeFormat/format.js

• "minute" and "hour" are now supported in 'text' contexts for relative time formatting.
• Also see the now passing test262 tests.

non262/Intl/NumberFormat/currency-sign-accounting.js
non262/Intl/NumberFormat/sign-display.js

• Referenced ICU bug has been fixed in ICU 65.

non262/Intl/NumberFormat/notation-compact-short.js

• 万亿 is preferred over 兆 in mainland China; CLDR sources were updated accordingly.

non262/Intl/NumberFormat/notation-engineering.js
non262/Intl/NumberFormat/notation-scientific.js

• ICU removed "E0" suffix for non-finite numbers in engineering and scientific contexts.

Comment 7

[André Bargull [:anba]]

Attachment: Bug 1583269 - Part 4: Update language tag mappings for CLDR 36. r=jwalden!

Depends on D49445

Comment 8

[André Bargull [:anba]]

Attachment: Bug 1583269 - Part 5: Updating ICU requires a clobber. r=jwalden!

Depends on D49447

Comment 9

[André Bargull [:anba]]

(Won't be landed before the soft-freeze has ended.)

Comment 10

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=701f59d95180f13150a376eb8bce9b4e204b645d

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/860578ad6430
Part 1: Remove custom patch to add thread-safety to icu::TimeZone::adoptDefault. r=jwalden
https://hg.mozilla.org/integration/autoland/rev/b6ae6f738d81
Part 2: Update in-tree ICU to release 65.1. r=jwalden
https://hg.mozilla.org/integration/autoland/rev/4e58a7aca4cd
Part 3: Update tests after ICU update. r=jwalden
https://hg.mozilla.org/integration/autoland/rev/1e653dca5610
Part 4: Update language tag mappings for CLDR 36. r=jwalden
https://hg.mozilla.org/integration/autoland/rev/1bf14b34d546
Part 5: Updating ICU requires a clobber. r=jwalden

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/860578ad6430
https://hg.mozilla.org/mozilla-central/rev/b6ae6f738d81
https://hg.mozilla.org/mozilla-central/rev/4e58a7aca4cd
https://hg.mozilla.org/mozilla-central/rev/1e653dca5610
https://hg.mozilla.org/mozilla-central/rev/1bf14b34d546