1583340 - Number input buttons in custom repeat dialog don't refresh preview

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Paul Morris [:pmorris]]

+++ This bug was initially created as a clone of Bug #1583098 +++

If you open a calendar event and then open the "repeats > custom" dialog, entering numbers by keyboard into the various number inputs refreshes the MiniMonth previews, but clicking the little +/- buttons doesn't.

onkeyup needs to be oninput as in bug 1583098.

Comment 1

[Paul Morris [:pmorris]]

Attachment: number-inputs-in-custom-repeat-dialog-0.patch

This fixes them. Will need uplift to comm-beta and comm-esr68.

Comment 2

[Paul Morris [:pmorris]]

Just as an aside, here are a few other places I found where we have this pattern of html:input type="number" with onchange. They might or might not need switching to oninput. (The 3rd one has both, but are both needed?)

https://searchfox.org/comm-central/source/mailnews/base/prefs/content/am-offline.xul#68
https://searchfox.org/comm-central/source/mailnews/extensions/newsblog/content/am-newsblog.xul#72
https://searchfox.org/comm-central/source/mailnews/extensions/newsblog/content/feed-subscriptions.xul#151

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9094734 [details] [diff] [review]
number-inputs-in-custom-repeat-dialog-0.patch

Huh. I guess that used to work when it was a XUL element.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/26a5aac20758
Fix number input buttons in custom repeat dialog. r=darktrojan

Comment 5

[Jorg K (CEST = GMT+2)]

Missed TB 68.1.1 but a few hours. Had Geoff set checkin-needed in the morning ...

Comment 6

[Jorg K (CEST = GMT+2)]

TB 70 beta 3:
https://hg.mozilla.org/releases/comm-beta/rev/b9d1924952c86655f8d1e50ed18864978d365b21

Comment 7

[Jorg K (CEST = GMT+2)]

TB 68.1.2 or TB 68.2 / Cal 7.0:
https://hg.mozilla.org/releases/comm-esr68/rev/0ae820b635216863c5bbdfc94e3a6e6c93a0ef0a