1583380 - Implement GeckoView's setVerticalClipping API for WebRender

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Botond Ballo [:botond]]

The setVerticalClipping API added in bug 1516048 is only implemented for non-WebRender.

WebRender requires a separate implementation. There is no AsyncCompositionManager (manager will be null here); instead, we likely need to enter Rust code and perform the clipping there.

Comment 1

[Chris Peterson [:cpeterson]]

Moving to the WebRender component.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

I've heard that GeckoView wants to provide an option whether the toolbar is positioned at the bottom or the top. So to me setVerticalClipping should take two values, one is for top and the other is bottom just like AsyncCompositionManager::SetFixedLayerMargins. (I assume there might be a demand that two toolbars are both on the top and the bottom) Also to me setVerticalClipping should be renamed to setFixedPositionMargins or something like that because it's for aligning position:fixed elements at the edge of the toolbar.

Comment 3

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1583380. Plumb a fixed position webrender animation id from the display list to the HitTestingTreeNode. r?botond

Comment 4

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1583380. Protect APZCTreeManager::mFixedLayerMargins by mMapLock instead of mTreeLock. r?botond

We do this because we will need to access it in APZCTreeManager::SampleForWebRender which can't hold mTreeLock.

Depends on D54399

Comment 5

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1583380. Refactor a helper out of nsLayoutUtils::SetFixedPositionLayerData to get the SideBits. r?botond

Depends on D54400

Comment 6

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1583380. Plumb SideBits from the display list to WebRenderScrollDataWrapper. r?botond

The plumbing from there to the HitTestingTreeNode is already in place for the non-webrender case.

Depends on D54401

Comment 7

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1583380. Collect fixed position info on APZCTreeManager and use that to provide transforms to webrender via SampleForWebRender. r?botond

Depends on D54402

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67364d4e1530
Plumb a fixed position webrender animation id from the display list to the HitTestingTreeNode. r=botond
https://hg.mozilla.org/integration/autoland/rev/e4253c5a9c9b
Protect APZCTreeManager::mFixedLayerMargins by mMapLock instead of mTreeLock. r=botond
https://hg.mozilla.org/integration/autoland/rev/606ebee120e2
Refactor a helper out of nsLayoutUtils::SetFixedPositionLayerData to get the SideBits. r=botond
https://hg.mozilla.org/integration/autoland/rev/9bfe410ce824
Plumb SideBits from the display list to WebRenderScrollDataWrapper. r=botond
https://hg.mozilla.org/integration/autoland/rev/4c1b0b497b1b
Collect fixed position info on APZCTreeManager and use that to provide transforms to webrender via SampleForWebRender. r=botond

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/67364d4e1530
https://hg.mozilla.org/mozilla-central/rev/e4253c5a9c9b
https://hg.mozilla.org/mozilla-central/rev/606ebee120e2
https://hg.mozilla.org/mozilla-central/rev/9bfe410ce824
https://hg.mozilla.org/mozilla-central/rev/4c1b0b497b1b