Closed
Bug 1583387
Opened 5 years ago
Closed 5 years ago
Cmd-Shift-F shortcut is not cancelled and triggers fullscreen on OSX
Categories
(DevTools :: Netmonitor, defect, P2)
DevTools
Netmonitor
Tracking
(firefox71 fixed)
RESOLVED
FIXED
Firefox 71
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: Harald, Assigned: abowler)
References
Details
(Keywords: good-first-bug)
Attachments
(1 file)
What were you doing?
Cmd-Shift-F in Network panel.
What happened?
Fullscreen is triggered and search panel opens.
What should have happened?
No fullscreen.
|
||
Comment 1•5 years ago
|
||
A few pointers for anyone interesting in fixing this:
-
The shortcut is handled here:
https://searchfox.org/mozilla-central/rev/153feabebc2d13bb4c29ef8adf104ec1ebd246ae/devtools/client/netmonitor/src/components/Toolbar.js#178 -
We should probably call
event.preventDefault();or something
Search the code base for examples:
https://searchfox.org/mozilla-central/search?q=this.shortcuts.on%28&case=true&path=
Honza
Keywords: good-first-bug
Please find my fix submitted below and let me know if anything further is needed for this.
|
|
||
Updated•5 years ago
|
Assignee: nobody → abowler2
Status: NEW → ASSIGNED
Pushed by jodvarko@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/36c6fe0b96ab prevent default Cmd-Shift-F shortcut from opening fullscreen on OSX r=Honza
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
You need to log in
before you can comment on or make changes to this bug.
Description
•