1583424 - Terminating a worker with breakpoint causes blank Debugger

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P1)

Description

[:Harald Kirschner :digitarald]

What were you doing?

1. Open debugger on https://firefox-devtools-tour.glitch.me/20190915/parity/#worker-debugging
2. Hit Spawn
3. Set a BP in the first line of the worker-task.js
4. Hit Kill

What happened?

Blank Debugger.

TypeError: "sources[actor] is undefined"
    findSource resource://devtools/client/debugger/src/components/PrimaryPanes/SourcesTree.js:51
    getSource resource://devtools/client/debugger/src/components/PrimaryPanes/SourcesTree.js:205
    SourcesTree resource://devtools/client/debugger/src/components/PrimaryPanes/SourcesTree.js:79
    isExpanded resource://devtools/client/debugger/src/components/shared/ManagedTree.js:126
    _dfs resource://devtools/client/debugger/dist/vendors.js:784
    _dfs resource://devtools/client/debugger/dist/vendors.js:798
    _dfs resource://devtools/client/debugger/dist/vendors.js:798
    _dfs resource://devtools/client/debugger/dist/vendors.js:798
    _dfsFromRoots resource://devtools/client/debugger/dist/vendors.js:814
    render resource://devtools/client/debugger/dist/vendors.js:1160
    finishClassComponent resource://devtools/client/shared/vendor/react-dom.js:10638
    updateClassComponent resource://devtools/client/shared/vendor/react-dom.js:10601
    beginWork resource://devtools/client/shared/vendor/react-dom.js:11419
    performUnitOfWork resource://devtools/client/shared/vendor/react-dom.js:14702
    workLoop resource://devtools/client/shared/vendor/react-dom.js:14720
    renderRoot resource://devtools/client/shared/vendor/react-dom.js:14803
    performWorkOnRoot resource://devtools/client/shared/vendor/react-dom.js:15655
    performWork resource://devtools/client/shared/vendor/react-dom.js:15567
    performSyncWork resource://devtools/client/shared/vendor/react-dom.js:15541
    requestWork resource://devtools/client/shared/vendor/react-dom.js:15410
    scheduleWork resource://devtools/client/shared/vendor/react-dom.js:15224
    enqueueSetState resource://devtools/client/shared/vendor/react-dom.js:8192
    setState React
    Redux 5
    waitUntilService resource://devtools/client/debugger/src/actions/utils/middleware/wait-service.js:71
    promiseMiddleware resource://devtools/client/debugger/src/actions/utils/middleware/promise.js:46
    context resource://devtools/client/debugger/src/actions/utils/middleware/context.js:35
    thunk resource://devtools/client/debugger/src/actions/utils/middleware/thunk.js:29
    dispatch Redux
    removeSourceActors resource://devtools/client/debugger/src/actions/source-actors.js:41
    thunk resource://devtools/client/debugger/src/actions/utils/middleware/thunk.js:29
    dispatch Redux
    updateThreads resource://devtools/client/debugger/src/actions/threads.js:30
react-dom.js:12769:13
Error while detaching the worker target front: undefined worker.js:90:15
TypeError: sources[actor] is undefined
SourcesTree.js:51:5
uncaught exception: Object

Comment 1

[:Harald Kirschner :digitarald]

Just hit this again while debugging the same page.

Comment 2

[Brian Hackett [Laid off!]]

Attachment: Bug 1583424 - Watch for missing threads in source tree, r=jlast.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa0e617660f2
Watch for missing threads in source tree, r=jlast.

Comment 4

[Cristina Coroiu [:ccoroiu]]

Backed out changeset aa0e617660f2 (bug 1583424) for devtools failures at devtools/client/debugger/test/mochitest/browser_dbg-worker-kill.js

Backout: https://hg.mozilla.org/integration/autoland/rev/5754d47440d65323c7e61667ad2b92f406bb98ae

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=aa0e617660f2dca171787b35a62f4e18b5e13939

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=268655583&repo=autoland&lineNumber=24890

task 2019-09-26T21:08:45.251Z] 21:08:45 INFO - GECKO(1155) | [Parent 1155, Main Thread] WARNING: NS_ENSURE_TRUE(!mHasOrHasHadOwnerWindow || mOwnerWindow) failed: file /builds/worker/workspace/build/src/dom/events/DOMEventTargetHelper.cpp, line 318
[task 2019-09-26T21:08:45.252Z] 21:08:45 INFO - GECKO(1155) | [Parent 1155, Main Thread] WARNING: NS_ENSURE_TRUE(!mHasOrHasHadOwnerWindow || mOwnerWindow) failed: file /builds/worker/workspace/build/src/dom/events/DOMEventTargetHelper.cpp, line 318
[task 2019-09-26T21:08:45.269Z] 21:08:45 INFO - GECKO(1155) | --DOMWINDOW == 19 (0x7f2a5b05f7a0) [pid = 1155] [serial = 779] [outer = (nil)] [url = about:devtools-toolbox]
[task 2019-09-26T21:08:45.269Z] 21:08:45 INFO - GECKO(1155) | --DOMWINDOW == 18 (0x7f2a5b05fb60) [pid = 1155] [serial = 783] [outer = (nil)] [url = chrome://devtools/content/debugger/index.html]
[task 2019-09-26T21:08:50.248Z] 21:08:50 INFO - GECKO(1155) | --DOMWINDOW == 17 (0x7f2a48ac4000) [pid = 1155] [serial = 784] [outer = (nil)] [url = about:blank]
[task 2019-09-26T21:08:50.248Z] 21:08:50 INFO - GECKO(1155) | --DOMWINDOW == 16 (0x7f2a48ac0800) [pid = 1155] [serial = 782] [outer = (nil)] [url = about:devtools-toolbox]
[task 2019-09-26T21:10:01.498Z] 21:10:01 INFO - TEST-INFO | started process screentopng
[task 2019-09-26T21:10:02.174Z] 21:10:02 INFO - TEST-INFO | screentopng: exit 0
[task 2019-09-26T21:10:02.175Z] 21:10:02 INFO - Buffered messages logged at 21:08:31
[task 2019-09-26T21:10:02.176Z] 21:10:02 INFO - Entering test bound
[task 2019-09-26T21:10:02.176Z] 21:10:02 INFO - Adding a new tab with URL: http://example.com/browser/devtools/client/debugger/test/mochitest/examples/doc-windowless-workers.html
[task 2019-09-26T21:10:02.176Z] 21:10:02 INFO - Tab added and finished loading
[task 2019-09-26T21:10:02.177Z] 21:10:02 INFO - Opening the toolbox
[task 2019-09-26T21:10:02.179Z] 21:10:02 INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://example.com/browser/devtools/client/debugger/test/mochitest/examples/doc-windowless-workers.html" line: 0}]
[task 2019-09-26T21:10:02.179Z] 21:10:02 INFO - Buffered messages logged at 21:08:35
[task 2019-09-26T21:10:02.180Z] 21:10:02 INFO - Toolbox opened and focused
[task 2019-09-26T21:10:02.180Z] 21:10:02 INFO - Buffered messages finished
[task 2019-09-26T21:10:02.180Z] 21:10:02 INFO - TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-worker-kill.js | Test timed out -
[task 2019-09-26T21:10:03.280Z] 21:10:03 INFO - Removing tab.
[task 2019-09-26T21:10:03.282Z] 21:10:03 INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2019-09-26T21:10:03.303Z] 21:10:03 INFO - Got event: 'TabClose' on [object XULElement].
[task 2019-09-26T21:10:03.327Z] 21:10:03 INFO - Tab removed and finished closing
[task 2019-09-26T21:10:03.376Z] 21:10:03 INFO - GECKO(1155) | --DOCSHELL 0x7f2a48d7d800 == 7 [pid = 1155] [id = {8b053db4-e608-48c9-b4ec-c6ad13bfe75a}] [url = chrome://devtools/content/debugger/index.html]
[task 2019-09-26T21:10:03.465Z] 21:10:03 INFO - GECKO(1155) | MEMORY STAT | vsize 3609MB | residentFast 487MB | heapAllocated 133MB
[task 2019-09-26T21:10:03.466Z] 21:10:03 INFO - TEST-OK | devtools/client/debugger/test/mochitest/browser_dbg-worker-kill.js | took 91999ms
[task 2019-09-26T21:10:03.509Z] 21:10:03 INFO - GECKO(1155) | ++DOCSHELL 0x7fadd0206800 == 2 [pid = 1284] [id = {ce42bd58-527c-430e-8b63-6d128b49395f}]
[task 2019-09-26T21:10:03.511Z] 21:10:03 INFO - GECKO(1155) | ++DOMWINDOW == 3 (0x7fadd2cf15c0) [pid = 1284] [serial = 315] [outer = (nil)]
[task 2019-09-26T21:10:03.512Z] 21:10:03 INFO - GECKO(1155) | ++DOMWINDOW == 4 (0x7fadd0266800) [pid = 1284] [serial = 316] [outer = 0x7fadd2cf15c0]
[task 2019-09-26T21:10:03.613Z] 21:10:03 INFO - GECKO(1155) | ++DOMWINDOW == 5 (0x7fadd026e800) [pid = 1284] [serial = 317] [outer = 0x7fadd2cf15c0]
[task 2019-09-26T21:10:03.633Z] 21:10:03 INFO - checking window state

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca5c8cdce0c9
Watch for missing threads in source tree, r=jlast.

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/ca5c8cdce0c9