1583428 - Fix image a11y labels in about:logins

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P2)

Description

[James Teh [:Jamie]]

I'd recommend two tweaks to image labels for accessibility in about:logins:

1. Favicons currently get an alt attribute with a string like "Favicon for login.yahoo.com". This ends up being extraneous verbosity for screen reader users, since the domain is already provided as text separately. I would instead set this to alt="".
2. Breach icons get an alt attribute of "Warning icon". That is the label that ends up getting used when the a11y engine builds the label for the list item. However, the more interesting part is the title of "Breached website", which currently does not get included in the label for the list item (because it is shadowed by alt). I would suggest removing the alt attribute and letting the title provide the label.

Please let me know if you'd prefer these as separate bugs an dI'll split one of them out.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Keeping as one bug is fine.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1583428 - Remove the alt attribute for the favicon since it is not helpful and remove the alt attribute on the breached website icon so the title of 'Breached Website' is spoken. r?sfoster

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8cec7bebba9
Remove the alt attribute for the favicon since it is not helpful and remove the alt attribute on the breached website icon so the title of 'Breached Website' is spoken. r=fluent-reviewers,MattN,flod

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/f8cec7bebba9

Comment 5

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Nightly (Build ID: 20191003214801) on Windows 7 x64 using the NVDA screen reader.

• The website's favicon is no longer read by the NVDA screen reader.
• The "Warning Icon" is no longer read by NVDA screen reader and the "Breached website" is read instead.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/releases/mozilla-beta/rev/570504a161f4

Comment 7

[Simona Rosu [:srosu], Ecosystem QA]

@Jared, I have verified this issue on the Firefox Beta 70.0b13 (Build ID: 20191007220302) on Windows 10 x64 using the NVDA screen reader and it seems to be only partially fixed.

• The website’s favicon in no longer read by the NVDA screen reader, but the “Warning icon” is still read by the NVDA screen reader.
• This issue is fixed on the latest Nightly 71.0a1 ( Build ID: 20191007215350) and the “Warning icon” is not read by the NVDA screen reader.

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Simona Rosu from comment #7)

@Jared, I have verified this issue on the Firefox Beta 70.0b13 (Build ID: 20191007220302) on Windows 10 x64 using the NVDA screen reader and it seems to be only partially fixed.

• The website’s favicon in no longer read by the NVDA screen reader, but the “Warning icon” is still read by the NVDA screen reader.
• This issue is fixed on the latest Nightly 71.0a1 ( Build ID: 20191007215350) and the “Warning icon” is not read by the NVDA screen reader.

This is expected since removing the 'alt' string from the Fluent file is considered changing a string and we can't change strings on Beta.

Comment 9

[Simona Rosu [:srosu], Ecosystem QA]

@Jared, thanks for clarification. I'll change the status as verified then.