1583467 - Arrows of custom scrollbar distort when zooming

Status: NEW

(Core :: Widget: Win32, defect)

Description

[Cristian Fogel [:cfogel]]

Attachment: darkTheme_navArrowsDisortOnZoom.gif

Affected versions

• 68.1.0esr, 69.0.1, 70.0b8, 71.0a1 (2019-09-23)

Affected platforms

• Windows 10,

Steps to reproduce

1. Launch Firefox, open DevTools, change it to Dark Theme;
2. Zoom in/out while the DevTools section is active - in focus;

Expected result

• the tool zooms as expected;

Actual result

• the scroll buttons are distorted on certain zoom levels;

Regression range

• First bad: build_date: 2018-10-09 21:38:52.481000 changeset: 91e7bbcc957a87805acaf96fe699df741f6a20ce
• Last good: build_date: 2018-10-09 21:31:17.603000 changeset: dd418f0ef29cf4082b1379211b601fcf950836da
• Pushlog: URL
• Potential regressor: 1494607

Additional notes

• attached recording with issue;
• default theme is not affected by this issue;

Comment 1

[Cristian Fogel [:cfogel]]

Hey Xidorn, mind taking a look?
It appears your patch may have caused this regression.

Thank you!

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

This happens on ordinary custom scrollbars in content as well, not devtools specific.

I had a look at the code and debugged a bit, but have totally no idea how to fix this with the current approach. I tried to inspect what scale we use when drawing, but it seems that the scale is always 1. Probably need someone with more knowledge about gfx to help...

Bas, could you shed some light on this? The related rendering code is: https://searchfox.org/mozilla-central/rev/b6f088f2f68d2a8ae0b49d6c8fbd7cbd3a65fa5b/widget/windows/nsNativeThemeWin.cpp#4262-4269

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

(Didn't mean to remove my own ni...)

Comment 4

[Bas Schouten (:bas.schouten)]

I suspect this is webrender related.

Nical?

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

I don't think this is webrender related, because I can reproduce this on a Windows instance on GCP, where WebRender seems to be disabled.

In about:support on this instance I see:

WEBRENDER	
opt-in by default: WebRender is an opt-in feature
unavailable-no-angle by runtime: ANGLE is disabled

WEBRENDER_QUALIFIED	
blacklisted by env: No qualified hardware

Actually, compositing shows "Basic" on that instance, which means hardware acceleration isn't enabled at all.

Comment 6

[Nicolas Silva [:nical]]

Sorry for the delay, I had some issues with my Windows machine.
I also have the same results with and without WebRender. I wonder if things get snapped slightly differently with the patch from 1494607 due to how some values that used to be computed using integers and then casted to floats are now computed with floats.
Other than that nothing jumps out but I don't know this code super well. The way it "looks" is reminiscent of the kind of issues you have when sizes or coordinates are off by a small amount, for example when trying to map a 100px surface to a 99px destination, etc.

Comment 7

[Pascal Chevrel:pascalc]

Wontfix for 70. Fix-optional for 71 given that we are going to beta in a few days and this is not a recent regression. We can evaluate an uplift if a safe patch materializes early in the 72 nightly cycle.

Comment 9

[Jack Douglas]

note that in bug 1611854, the scroll buttons are distorted at normal zoom level.