1583516 - Add 2-axis telemetry to the JS Shell.

Status: ASSIGNED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Nicolas B. Pierron [:nbp]]

The telemetry API only capture a single axis, but nothing prevent the JS shell from capturing more than a single axis of data. This bug is about adding XY (2-axis) data reports to the JS Shell.

For example, here is data collected with the up-coming patch which measures the time & speed of the full-parser while parsing LazyScripts: https://docs.google.com/spreadsheets/d/1ugtNJl9U_I7Z69AXOIb2NbJgsAPTz3oYiqUziXMVAhc/edit?usp=sharing

Comment 1

[Nicolas B. Pierron [:nbp]]

Attachment: Bug 1583516 - Add 2-axis telemetry for the JS Shell.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:nbp, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ecd87c380c0e
Add 2-axis telemetry for the JS Shell. r=jorendorff

Comment 4

[Cristina Coroiu [:ccoroiu]]

Backed out 2 changesets (bug 1583516, bug 1582804) for causing sm bustages on js.cpp

Backout: https://hg.mozilla.org/integration/autoland/rev/a208be69ed13c5ac27a31bfff15ae86c11f1c856

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=ecd87c380c0edc3cad760f8831175871537f0509

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=319259338&repo=autoland&lineNumber=4031

Comment 5

[Nicolas B. Pierron [:nbp]]

(In reply to Cristina Coroiu [:ccoroiu] from comment #4)

Backed out 2 changesets (bug 1583516, bug 1582804) for causing sm bustages on js.cpp

The reason of the backout is that compiler are complaining about adding support for telemetry probe without having any probe added.
Thus, I suggest that this patch should be merged once we have a need a probe which would be implemented in a later patch …