1583541 - FIll Password/Use secure password disabled in case of Master password

Status: NEW

(Toolkit :: Password Manager, defect, P4)

Description

[Adrian Florinescu [:aflorinescu]]

[Environment:]

Windows 10 Pro
Firefox 70.0b9 20190923154733
Firefox 71.0a1 20190924094348

[Preconditions:]

Have a master password set.
Have the browser closed.

[Steps:]

1. Open Firefox.
2. Open any login form. (it doesn't contain any logins)
3. Right click on the password field, select Fill Password/Generate Secure Password.

[Actual Result:]

The Fill Password is disabled, you cannot select Fill Password and trigger master password dialog.

[Expected Result:]

Fill Passwords / Generate Secure Password is selectable
On Generate Secure Password, master password is displayed.

• parity with the case in which password field is autocomplete="new-password"

[Note:]
Before generate passwords, having the Fill Password context menu disabled made sense in the no logins scenario, since there were no passwords to be shown; but starting with generate passwords features even when I have no passwords saved for the target login, I will want to be able to generate. (e.g. the registration form case)

Comment 1

[Sam Foster [:sfoster] (he/him)]

Right now the whole Fill Passwords contextmenu item is disabled if you have not unlocked your master password. We could potentially enable it and have a "unlock your master password" button where the logins list would be on the submenu. That would allow the user to get to the fill generated password item in the submenu.