158356 - We need to replace those HGnnnn macro with the correct code

Status: RESOLVED WORKSFORME

(MailNews Core :: Security: S/MIME, defect, P1)

Description

[Jean-Francois Ducarroz]

When we adapt MIME in Mozilla, old security code were replaced by Macro begining
with HG. Now that security support have been re-implemented in the code, we need
to replace those macro with the right code. Unfortunalty, we lost the file that
contains the definition of those macro. Therefore the easy way to do it is to
look into Nova code (file and function name should be the same) to find the
missing peace:

\mozilla\mailnews\mime\src\mimedrft.cpp(1285):HG88890
\mozilla\mailnews\mime\src\mimehdrs.cpp(812): HG99401
\mozilla\mailnews\mime\src\mimemsg.cpp(74):   HG56268
\mozilla\mailnews\mime\src\mimemsg.cpp(156):  HG11013
\mozilla\mailnews\mime\src\mimemsg.cpp(657):  HG33391
\mozilla\mailnews\mime\src\mimemsg.cpp(726):  HG00919 
\mozilla\mailnews\mime\src\mimemsg.cpp(739):  HG11995
\mozilla\mailnews\mime\src\mimepbuf.h(58):    HG37486

some other macros are covered by bug 141730.

Comment 1

[Kai Engert [:KaiE:]]

over to PSM.

Comment 2

[Kai Engert [:KaiE:]]

JF said the following about two of the comments, making them obsolete:

"HG33391 & HG00919 They are about adding a security stamp in the headers
displayed. I don't thisg they are needed anymore in Mozilla therefore feel free
to remove them..."

Comment 3

[Kai Engert [:KaiE:]]

changing obsolete psm* target to --- (unspecified)

Comment 4

[Magnus Melin [:mkmelin]]

Gone since long. Apparently bug 471376 and others.