1583582 - mach bootstrap fails on arch linux

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, defect)

Description

[Greyson Gilbert]

Attachment: os-release

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

run mach bootstrap on arch linux

Actual results:

KeyError: u'VERSION_ID' at https://searchfox.org/mozilla-central/source/python/mozboot/mozboot/bootstrap.py#260

VERSION_ID is an optional field and arch doesn't supply it.

Expected results:

Script should run successfully.

Comment 1

[Frederik Braun [:freddy]]

Looks like bug 1581921 introduced this

Comment 2

[Dzmitry Malyshau [:kvark]]

Uh oh, sorry about that!
Do you want to try fixing this? If not, I can try, but I don't have Arch sitting around.

Comment 3

[Kenny Levinsen :kennylevinsen]

Attachment: Bug 1583582 - Mach should not depend on fields in /etc/os-release. r=kvark

Some fields of /etc/os-release are optional, so do not throw KeyError's when they're missing.

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/integration/autoland/rev/b4e9b21cd886e4d22997ff24abf941d363f5bfb5

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/b4e9b21cd886