Closed
Bug 1583624
Opened 6 years ago
Closed 6 years ago
Unclear error message in stylebench raptor output.
Categories
(Testing :: Raptor, enhancement, P1)
Tracking
(firefox71 fixed)
RESOLVED
FIXED
mozilla71
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: sparky, Assigned: onegru)
References
(Regression)
Details
Attachments
(1 file)
This should have been addressed in the review for bug 1565316 (I recall pointing this out).
The line here says "StyleBench has 380 entries, found: %s instead". It should say "StyleBench requires 380 entries, found %s instead.". The 'has' makes it sound like we did find 380 and are reporting some other number in the 'instead' part of the error.
| Reporter | ||
Updated•6 years ago
|
Flags: needinfo?(tarek)
Flags: needinfo?(nalexander)
Comment 1•6 years ago
|
||
Yeah let's fix it. It probably was lost in the process, we had many merges etc sorry!
Flags: needinfo?(tarek)
Updated•6 years ago
|
Type: defect → enhancement
| Assignee | ||
Updated•6 years ago
|
Assignee: nobody → onegru
Updated•6 years ago
|
Priority: -- → P1
| Assignee | ||
Comment 2•6 years ago
|
||
Pushed by fstrugariu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ef5296a9eed8
Unclear error message in stylebench raptor output. r=perftest-reviewers,Marian
Comment 4•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Updated•6 years ago
|
Flags: needinfo?(nalexander)
Updated•4 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•