1583625 - Two Master Password dialog appear at the same time when Click [Saved Logins...] button in about:preferences#privacy

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P1)

Description

[Alice0775 White]

[Tracking Requested - why for this release]: ux regression

Reproducible: always

Steps To reproduce:

1. Add a Login password if there is no saved login
2. Enable Master Password and set Master Password
3. Quit browser and restart browser
4. Menu > Options > Privacy & Security
5. Click [Saved Logins...] button

Actual Results:
Two Master Password dialog appear at the same time

Expected Results:
Only one Master Password dialog should appear

Interesting thing, if open "about:logins" directly, no issue appears.

Regression Window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5d60ea8fbdc6a265b67bcabcdf845f26615c97c8&tochange=571a8776eb3fc71a73d491efcbd75bab140923ec

Regressed by: Bug 1550631

Comment 1

[Alice0775 White]

Attachment: Screencast

Comment 2

[Pascal Chevrel:pascalc (PTO until Sept 2)]

Marking 70 as affected as the regressor just got uplifted to beta.

Comment 3

[Matthew N. [:MattN]]

Attachment: Bug 1583625 - Don't dispatch AboutLoginsInit after redirecting to remove the entryPoint. r=jaws

Depends on D47101

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b7c5d0a5fe2
Don't dispatch AboutLoginsInit after redirecting to remove the entryPoint. r=jaws

Comment 5

[Matthew N. [:MattN]]

Comment on attachment 9095209 [details]
Bug 1583625 - Don't dispatch AboutLoginsInit after redirecting to remove the entryPoint. r=jaws

Beta/Release Uplift Approval Request

• User impact if declined: The load of about:logins will do unnecessary work, making it slower and showing an extra MP prompt if MP is enabled.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Straightforward fix. Putting two lines inside an if to be skipped after redirecting to remove the telemetry query parameter.
• String changes made/needed: None

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9095209 [details]
Bug 1583625 - Don't dispatch AboutLoginsInit after redirecting to remove the entryPoint. r=jaws

Fix for new regression in 70, OK for uplift for beta 10.

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/2b7c5d0a5fe2

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/480bfb1bbe28

Comment 9

[(PTO until Sept 5) Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue and is no longer reproducible on the latest Nightly 71.0a1 (Build ID: 20190925215653) on Windows 7 x64, Mac 10.14 and Arch 14.14 x64.

• Only one Master Password dialog appears using the following methods:
  Navigating directly to about:logins or from the bookmark.
  Navigating from "about:protections" page.
  Navigating from Firefox Account menu.
  Navigating from Hamburger main menu.
  Navigating from Page Info window.
  Navigating from "about:preferences".

Comment 10

[(PTO until Sept 5) Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue and is no longer reproducible on the latest Beta 70.0b10 (Build ID: 20190926005616) on Windows 7 x64, Mac 10.14 and Arch 14.14 x64.

• Only one Master Password dialog appears using the following methods:
  • Navigating directly to about:logins or from the bookmark.
  • Navigating from "about:protections" page.
  • Navigating from Firefox Account menu.
  • Navigating from Hamburger main menu.
  • Navigating from Page Info window.
  • Navigating from "about:preferences".