1583634 - [Protections Panel] Update subpanel arrows

Status: VERIFIED FIXED

(Firefox :: Site Identity, task, P3)

Description

[Eric Pang [:epang] UX]

Attachment: subpanel arrows.png

Update the subpanel arrows in the protections and site identity panel to match the colour and weight of the ones used in the application menu for consistency.

Comment 1

[Johann Hofmann [:johannh]]

Eric, can you check if we want to actually make the arrows lighter instead of updating the application menu arrows?

Comment 2

[Eric Pang [:epang] UX]

I spoke to Stephen Horlander about this. We're going to match the lighter arrows in the application menu since they pass the contrast ratio check. Thanks!

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1583634 - Make dropmarker arrows lighter in the protections and identity panels. r=johannh

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4874057c0c47
Make dropmarker arrows lighter in the protections and identity panels. r=timhuang

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/4874057c0c47

Comment 6

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 9096920 [details]
Bug 1583634 - Make dropmarker arrows lighter in the protections and identity panels. r=johannh

Beta/Release Uplift Approval Request

• User impact if declined: Inconsistent visuals (color of the arrows in the protections panel vs arrows in other panels, e.g. bookmarks panel)
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small change, visual polish.
• String changes made/needed:

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9096920 [details]
Bug 1583634 - Make dropmarker arrows lighter in the protections and identity panels. r=johannh

Polish for Skyline feature, OK for uplift for beta 12.

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/releases/mozilla-beta/rev/aedbd2770962

Comment 9

[Ciprian Georgiu, Desktop QA]

Reproduced this bug using an affected Nightly build from 2019-09-24.

I can confirm that the arrows are using now a lighter contrast in protections and identity panel. Tested on OS X 10.11, Windows 10 x64 and Ubuntu 18.04 x64 with Beta 70.0b12, Nightly 71.0a1.