Closed Bug 1583634 Opened 4 months ago Closed 4 months ago

[Protections Panel] Update subpanel arrows

Categories

(Firefox :: Site Identity, task, P3)

task

Tracking

()

VERIFIED FIXED
Firefox 71
Tracking Status
firefox70 --- verified
firefox71 --- verified

People

(Reporter: epang, Assigned: nhnt11)

References

(Blocks 1 open bug)

Details

(Whiteboard: [privacy-panel][triage][skyline])

Attachments

(2 files)

Attached image subpanel arrows.png

Update the subpanel arrows in the protections and site identity panel to match the colour and weight of the ones used in the application menu for consistency.

Eric, can you check if we want to actually make the arrows lighter instead of updating the application menu arrows?

Flags: needinfo?(epang)

I spoke to Stephen Horlander about this. We're going to match the lighter arrows in the application menu since they pass the contrast ratio check. Thanks!

Flags: needinfo?(epang)
Priority: -- → P3
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4874057c0c47
Make dropmarker arrows lighter in the protections and identity panels. r=timhuang
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

Comment on attachment 9096920 [details]
Bug 1583634 - Make dropmarker arrows lighter in the protections and identity panels. r=johannh

Beta/Release Uplift Approval Request

  • User impact if declined: Inconsistent visuals (color of the arrows in the protections panel vs arrows in other panels, e.g. bookmarks panel)
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Small change, visual polish.
  • String changes made/needed:
Attachment #9096920 - Flags: approval-mozilla-beta?

Comment on attachment 9096920 [details]
Bug 1583634 - Make dropmarker arrows lighter in the protections and identity panels. r=johannh

Polish for Skyline feature, OK for uplift for beta 12.

Attachment #9096920 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Reproduced this bug using an affected Nightly build from 2019-09-24.

I can confirm that the arrows are using now a lighter contrast in protections and identity panel. Tested on OS X 10.11, Windows 10 x64 and Ubuntu 18.04 x64 with Beta 70.0b12, Nightly 71.0a1.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.