1583732 - [Wayland] Don't use dmabuf wayland buffer for partial screen updates

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement, P3)

Description

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Dmabuf wayland buffer in basic compositor should be used for fullscreen (whole buffer) updates only (if even).

Comment 1

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1583732 [Wayland] Add IsDMABufBuffer identification to WindowBackBuffer, r=jhorak

Comment 2

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1583732 [Wayland] Refactor wayland buffer creation, r=jhorak

Don't use GetWaylandBufferToDraw() method to get/create wayland buffer
but split it to smaller methods:

GetPartialWaylandBuffer() - get wayland bufer for partial screen update
GetFullScreenWaylandBuffer() - get wayland buffer for fullscreen update, buffer
can be switched/changed.

SetNewWaylandBuffer() - changes active wayland buffer or create a new one.

Depends on D47890

Comment 3

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1583732 [Wayland] Allow direct buffer rendering for large screen updates only, r=jhorak

When CACHE_MISSING image cache is selected we draw directly to wayland buffer if it's available
and cache drawing when wayland buffer is missing only. That produces flickering when small buffer parts are
sent to compositor early and the buffer is blocked for further rendering.

This patch enables direct rendering of bigger screen parts only (like page scrolling) to eliminate small
buffer updates.

Depends on D47891

Comment 4

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1583732 [Wayland] Use DMABUF for fullscreen updates only, r=jhorak

• Use two sets of wayland buffers (shm and dmabuf) and use dmabuf for fullscreen updates only
  when dmabuf is enabled.

• Fix buffered rendering, disable direct rendering for CACHE_ALL

• Rename GetFullScreenWaylandBuffer() to GetWaylandBufferWithSwitch() and
  GetPartialWaylandBuffer() to GetWaylandBufferRecent() to better reflect
  actual roles.

Depends on D47892

Comment 5

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1583732 [Wayland] Use DMABUF for fullscreen updates only, r=jhorak

Add IsDMABufBuffer identification to WindowBackBuffer

Use two sets of wayland buffers (shm and dmabuf) and use dmabuf for fullscreen updates only
when dmabuf is enabled.

Don't use GetWaylandBufferToDraw() method to get/create wayland buffer
but split it to smaller methods:

GetPartialWaylandBuffer() - get wayland bufer for partial screen update
GetFullScreenWaylandBuffer() - get wayland buffer for fullscreen update, buffer
can be switched/changed.

SetNewWaylandBuffer() - changes active wayland buffer or create a new one.

When CACHE_MISSING image cache is selected we draw directly to wayland buffer if it's available
and cache drawing when wayland buffer is missing only. That produces flickering when small buffer parts are
sent to compositor early and the buffer is blocked for further rendering.

This patch enables direct rendering of bigger screen parts only (like page scrolling) to eliminate small
buffer updates.

Rename GetFullScreenWaylandBuffer() to GetWaylandBufferWithSwitch() and
GetPartialWaylandBuffer() to GetWaylandBufferRecent() to better reflect
actual roles.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83c16dc95d13
[Wayland] Use DMABUF for fullscreen updates only, r=jhorak

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/83c16dc95d13