1583841 - Smart profiler HUD

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P3)

Description

[Nicolas Silva [:nical]]

The builtin webrender profiler HUD is too large to display at all times. The compact profiler is useful but it doesn't always have the relevant information.

I would like to have a profiler that only shows information when the value is higher than a certain value. For example only show the number of draw calls if it is greater than 80, only show the number of alpha targets if it is greater than 2, etc.
If a field is displayed, keep it for a second to avoid blinking.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 1583841 - Add a smart profiler HUD. r=jrmuizel

Comment 2

[Nicolas Silva [:nical]]

Attachment: Bug 1583841 - Define some expected ranges for webrender's smart profiler.

Depends on D48969

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8aeb2407e5e5
Add a smart profiler HUD. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/9b5653a5fae4
Define some expected ranges for webrender's smart profiler. r=gw

Comment 4

[Nicolas Silva [:nical]]

Attachment: Bug 1583841 - Add an expected range in ResourceProfileCounter. r=gw

Depends on D49438

Comment 5

[Nicolas Silva [:nical]]

Attachment: Bug 1583841 - Include some ResourceProfileCounters in the smart profiler. r=gw

Depends on D49617

Comment 6

[Nicolas Silva [:nical]]

Attachment: Bug 1583841 - Highlight values in red in the full and compact profilers when values are outside their expected range. r=gw

Depends on D49618

Comment 7

[Nicolas Silva [:nical]]

Attachment: Bug 1583841 - Don't set an expected range for the FPS counter. r=gw

When we are not scrolling or animating it can be normal for there to be a long pause between frames, in which case highlighting the FPS counter in the profiler is distracting.

Depends on D49619

Comment 8

[Nicolas Silva [:nical]]

Attachment: Bug 1583841 - Adjust expected gpu cache blocks constants. r=kvark

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/8aeb2407e5e5
https://hg.mozilla.org/mozilla-central/rev/9b5653a5fae4

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5979a2132006
Add an expected range in ResourceProfileCounter. r=gw
https://hg.mozilla.org/integration/autoland/rev/8cc42e92e6ef
Include some ResourceProfileCounters in the smart profiler. r=gw
https://hg.mozilla.org/integration/autoland/rev/16bed925e3ac
Highlight values in red in the full and compact profilers when values are outside their expected range. r=gw
https://hg.mozilla.org/integration/autoland/rev/1ad5346d3fa4
Don't set an expected range for the FPS counter. r=gw

Comment 11

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/5979a2132006
https://hg.mozilla.org/mozilla-central/rev/8cc42e92e6ef
https://hg.mozilla.org/mozilla-central/rev/16bed925e3ac
https://hg.mozilla.org/mozilla-central/rev/1ad5346d3fa4

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06e6c1909fe1
Adjust expected gpu cache blocks constants. r=kvark

Comment 13

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/06e6c1909fe1