Closed Bug 1583848 Opened 5 years ago Closed 5 years ago

A blue light background is wrongly displayed around the “GET IT ON Google Play” button from mobile promotion on Linux

Categories

(Core :: Graphics: ImageLib, defect, P1)

71 Branch
defect

Tracking

()

VERIFIED FIXED
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox69 --- unaffected
firefox70 --- unaffected
firefox71 blocking verified

People

(Reporter: srosu, Assigned: aosmond)

References

(Regression)

Details

(Keywords: rca-needed, regression, Whiteboard: [passwords:management] [skyline] [fixed by the backout of patch from bug #1551088])

Attachments

(3 files)

Attached image MobilePromotion.png

[Affected versions]:

  • Nightly 71.0a1 (Build ID: 20190924215237) (64-bit)

[Affected Platforms]:

  • Ubuntu 18.04 x64.
  • Arch Linux 4.12

[Prerequisites]:

  • You are signed with a valid FxA account.

[Steps to reproduce]:

  1. Open the Firefox browser with the profile from prerequisites.
  2. Navigate to “about:logins” page.
  3. Observe the the “GET IT ON Google Play” button from the mobile promotion.

[Expected result]:

  • The “GET IT ON Google Play” button has not a background around it.

[Actual result]:

  • The “GET IT ON Google Play” button has a blue light background around it.

[Regression Window]

  • The issue is not reproducible with older Nightly 71.0a1 (2019-09-25) builds. Considering this, using mozregression tool I have found the issue that broke this in the latest Nightly build. Here are the results:
  • Pushlog: https://tinyurl.com/y2y7rvbm
  • Last good revision: 792734411e2f2fa383f0134f6549d0096b4d8da7
  • First bad revision: 9ef391e20fa6d7c0a0f097bda04d61f1d4d4d8f2

From this pushlog it seems that bug 1551088 introduced this behavior.

[Notes]:

  • Attached a screenshot with the issue.
Flags: needinfo?(aosmond)
Assignee: nobody → aosmond
Component: Password Manager → ImageLib
Priority: -- → P1
Product: Toolkit → Core
Version: unspecified → Trunk
Has Regression Range: --- → yes
Has STR: --- → yes
Hardware: Desktop → All
Severity: normal → major

Similar corruption is visible in the favicon for https://phabricator.services.mozilla.com/ (shown e.g. in the tab strip). It's got unexpected green corners that should be transparent.

I see the same issue if I view the icon directly and zoom out with full page zoom.

I presume the GMail logo background is the same issue.

This was fixed by the backout of bug 1551088

Flags: needinfo?(aosmond)
Status: NEW → RESOLVED
Closed: 5 years ago
QA Contact: Virtual
Resolution: --- → FIXED
Whiteboard: [passwords:management] [skyline] → [passwords:management] [skyline] [fixed by the backout of patch from bug #1551088]
Version: Trunk → 71 Branch

This bug has been identified as part of a pilot on determining root causes of blocking and dot release drivers.

It needs a root-cause set for it. Please see the list at https://docs.google.com/document/d/1FFEGsmoU8T0N8R9kk-MXWptOPtXXXRRIe4vQo3_HgMw/.

Add the root cause as a whiteboard tag in the form [rca - <cause> ] and remove the rca-needed keyword.

If you have questions, please contact :tmaity.

Keywords: rca-needed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: