1583867 - Add rtpTimestamp support to RTP synchronization and contributing sources

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement, P2)

Description

[Nico Grunbaum [:ng, @chew:mozilla.org]]

The RTCRtpSynchronizationSources and RTCRtpContributing sources has changed to include the RTP timestamp from the original packet. We should add support for this to our implementation.

Comment 1

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1583867 - add rtpTimestamp field to RTP sync/contrib sources; r?jib

Comment 2

[Nico Grunbaum [:ng, @chew:mozilla.org]]

WebIDL review information:

File that needs DOM review: https://phabricator.services.mozilla.com/D47096#change-zpLZvSrD8snN
Spec Info: WebRTC-PC[0] added the rtpTimestamp field to RTPContributingSource[1], this patch adds support for that field, note RTPSynchronizationSource inherits from RTPContributingSource

[0] https://rawgit.com/w3c/webrtc-pc/master/webrtc.html
[1] https://rawgit.com/w3c/webrtc-pc/master/webrtc.html#dom-rtcrtpcontributingsource

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62b78793d12e
add rtpTimestamp field to RTP sync/contrib sources; r=jib,smaug

Comment 4

[Dorel Luca [:dluca]]

Backed out changeset 62b78793d12e (bug 1583867) for WPT failures in webrtc/RTCRtpReceiver-getSynchronizationSources.https.html

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=269528611&repo=autoland&lineNumber=83033

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=62b78793d12ea17f04df42352e4e8db27fa6a908

Backout:
https://hg.mozilla.org/integration/autoland/rev/cd5563f698cd2dd731bf94b91fe0b82f7cbbd1d5

Comment 5

[Nico Grunbaum [:ng, @chew:mozilla.org]]

I am running on Try with an expected PASS, however it may be that the test suite itself has inconsistent results and that the test should really be NOT RUN for now. https://treeherder.mozilla.org/#/jobs?repo=try&revision=325a0867291121031e33d17303f587d8782268ea
If so I would like to look at fixing these tests in another bug.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:ng, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 7

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc8e29ae2e8353c5690270e93b390f264eff22b2

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9ed98e8618a
add rtpTimestamp field to RTP sync/contrib sources; r=jib,smaug

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/a9ed98e8618a

Comment 10

[Eric Shepherd [:sheppy]]

Documentation updated:

• https://developer.mozilla.org/en-US/docs/Web/API/RTCRtpContributingSource
• https://developer.mozilla.org/en-US/docs/Web/API/RTCRtpContributingSource/rtpTimestamp
• https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/72