Closed Bug 1583867 Opened 2 years ago Closed 2 years ago

Add rtpTimestamp support to RTP synchronization and contributing sources

Categories

(Core :: WebRTC, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: ng, Assigned: ng, NeedInfo)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

The RTCRtpSynchronizationSources and RTCRtpContributing sources has changed to include the RTP timestamp from the original packet. We should add support for this to our implementation.

WebIDL review information:

File that needs DOM review: https://phabricator.services.mozilla.com/D47096#change-zpLZvSrD8snN
Spec Info: WebRTC-PC[0] added the rtpTimestamp field to RTPContributingSource[1], this patch adds support for that field, note RTPSynchronizationSource inherits from RTPContributingSource

[0] https://rawgit.com/w3c/webrtc-pc/master/webrtc.html
[1] https://rawgit.com/w3c/webrtc-pc/master/webrtc.html#dom-rtcrtpcontributingsource

Pushed by na-g@nostrum.com:
https://hg.mozilla.org/integration/autoland/rev/62b78793d12e
add rtpTimestamp field to RTP sync/contrib sources; r=jib,smaug

I am running on Try with an expected PASS, however it may be that the test suite itself has inconsistent results and that the test should really be NOT RUN for now. https://treeherder.mozilla.org/#/jobs?repo=try&revision=325a0867291121031e33d17303f587d8782268ea
If so I would like to look at fixing these tests in another bug.

Flags: needinfo?(na-g)

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:ng, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(na-g)
Pushed by na-g@nostrum.com:
https://hg.mozilla.org/integration/autoland/rev/a9ed98e8618a
add rtpTimestamp field to RTP sync/contrib sources; r=jib,smaug
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.