Add rtpTimestamp support to RTP synchronization and contributing sources
Categories
(Core :: WebRTC, enhancement, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: ng, Assigned: ng, NeedInfo)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
The RTCRtpSynchronizationSources and RTCRtpContributing sources has changed to include the RTP timestamp from the original packet. We should add support for this to our implementation.
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
•
|
||
WebIDL review information:
File that needs DOM review: https://phabricator.services.mozilla.com/D47096#change-zpLZvSrD8snN
Spec Info: WebRTC-PC[0] added the rtpTimestamp field to RTPContributingSource[1], this patch adds support for that field, note RTPSynchronizationSource inherits from RTPContributingSource
[0] https://rawgit.com/w3c/webrtc-pc/master/webrtc.html
[1] https://rawgit.com/w3c/webrtc-pc/master/webrtc.html#dom-rtcrtpcontributingsource
|
||
Updated•3 years ago
|
Pushed by na-g@nostrum.com: https://hg.mozilla.org/integration/autoland/rev/62b78793d12e add rtpTimestamp field to RTP sync/contrib sources; r=jib,smaug
|
||
Comment 4•3 years ago
|
||
Backed out changeset 62b78793d12e (bug 1583867) for WPT failures in webrtc/RTCRtpReceiver-getSynchronizationSources.https.html
Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=269528611&repo=autoland&lineNumber=83033
Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=62b78793d12ea17f04df42352e4e8db27fa6a908
Backout:
https://hg.mozilla.org/integration/autoland/rev/cd5563f698cd2dd731bf94b91fe0b82f7cbbd1d5
|
|
Assignee | |
Comment 5•3 years ago
|
||
I am running on Try with an expected PASS, however it may be that the test suite itself has inconsistent results and that the test should really be NOT RUN for now. https://treeherder.mozilla.org/#/jobs?repo=try&revision=325a0867291121031e33d17303f587d8782268ea
If so I would like to look at fixing these tests in another bug.
|
||
Comment 6•3 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:ng, could you have a look please?
For more information, please visit auto_nag documentation.
|
|
Assignee | |
Comment 7•3 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc8e29ae2e8353c5690270e93b390f264eff22b2
Pushed by na-g@nostrum.com: https://hg.mozilla.org/integration/autoland/rev/a9ed98e8618a add rtpTimestamp field to RTP sync/contrib sources; r=jib,smaug
|
|
||
Comment 9•3 years ago
|
||
| bugherder | ||
Description
•