1583891 - about:debugging should show origin attributes for dFPI and FPI

Status: RESOLVED FIXED

(DevTools :: about:debugging, enhancement, P3)

Description

[Tom Ritter [:tjr]]

reddit.com registers a Service Worker, so from a new profile, go to reddit, and see the service worker in about:serviceworkers and about:debugging. Then enable privacy.firstparty.isolate and go to reddit again. about:serviceworkers will show two; about:debugging only one.

I also noticed that if you get a Service Worker for the same domain in different Containers (User Context Ids) it's not possible to distinguish them on about:debugging.

I tried following the code to where we list SWs different in about:serviceworkers and about:debugging but was not able to find it...

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:jdescottes, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Julian Descottes [:jdescottes]]

Feel free to bump the priority if you feel like this is a blocking issue.
I don't think the user impact is huge, but I'm open to discuss this.

Comment 3

[:Harald Kirschner :digitarald]

Belen, should we track this for Application panel as well or is it not affected?

Comment 4

[Gary Chen [:xeonchen]]

There's no Service Worker with First-Party Domain when dFPI is on, only 1 is shown in about:serviceworkers and about:debugging.

Comment 5

[Johann Hofmann [:johannh]]

That reads like dFPI isn't affected, removing the meta bug.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Clear a needinfo that is pending on an inactive user.

For more information, please visit auto_nag documentation.

Comment 7

[Fatih Kilic [:fkilic]]

Could this issue be already fixed somehow? I'm getting two service workers. https://www.reddit.com^firstPartyDomain=reddit.com and https://www.reddit.com. Both of them appear in about:debugging and about:serviceworkers, altough about:serviceworkers show firstPartyDomain too while about:debugging doesn't. I couldn't really find out why.

It seems we fetch the service workers here https://searchfox.org/mozilla-central/rev/0386e3e47504286ee176ab373a0562262e7c98b4/devtools/client/aboutdebugging/src/actions/debug-targets.js#291-321, but I don't know what exactly we get. I can try to fix it if we get the principal in that function.

Comment 8

[Tom Ritter [:tjr]]

Well, the fact that it doesn't show on about:debugging is fixed, but I think we would still want a way to distinguish between the two there...

Comment 9

[Fatih Kilic [:fkilic]]

Attachment: Bug 1583891: Display workers' origin attributes. r?tjr

This patch aims to match URL's shown in about:serviceworkers and about:debugging page.

By switching to origin instead of URL, we can differentiate service workers registered in third party contexts and FPI.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f19c57ab591
Display workers' origin attributes. r=devtools-reviewers,fluent-reviewers,bolsson,ochameau

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0f19c57ab591