1583903 - [Inactive CSS] Display a warning when properties only applying to replaced elements are used on non-replaced elements

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, enhancement, P2)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Main file:
devtools/server/actors/utils/inactive-property-helper.js

invalidProperties: [
"crop",
"object-fit",
"object-position",
]

inactive-css-only-replaced-elements = <strong>{ $property }</strong> has no effect on this element since it can only be applied to replaced elements.

inactive-css-only-replaced-elements-fix = Ensure you are adding the property to a replaced element. { learn-more }

Comment 1

[Sebastian Zartner [:sebo]]

As far as I know, there is no crop property. There was one defined a long time ago in CSS Content 3, though it got dropped at some point. So I guess we're left with object-fit and object-position.

Sebastian

Comment 2

[Sebastian Zartner [:sebo]]

Attachment: Bug 1583903 - [devtools] Handle properties only applying to replaced elements in inactive CSS. r=#devtools-reviewers.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b280eb51e7f2
[devtools] Handle properties only applying to replaced elements in inactive CSS. r=devtools-reviewers,fluent-reviewers,bolsson,nchevobbe.

Comment 4

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/b280eb51e7f2