Closed Bug 1583941 Opened 4 months ago Closed 4 months ago

Use a more optimal way to communicate dark mode changes from LightweightThemeConsumer.jsm

Categories

(Toolkit :: Add-ons Manager, task)

task
Not set

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

From https://phabricator.services.mozilla.com/D45926:

I think it would be better to have _update dispatch an event and let browser.js listen to that instead of observing lightweight-theme-styling-update. Feel free to do that here and re-request review, or else we could file a followup.

This bug is the followup.

So I don't loose track of this.

Flags: needinfo?(emilio)
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/83201310a062
Use a per-window event to handle dark mode changes in LightweightThemeConsumer.jsm. r=dao
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71

Hello,
Will this require manual validation from the qa side? If yes, please provide some steps to reproduce in order to correctly test it. Otherwise, could the "qe-verify-" flag be added? Thanks!

Flags: needinfo?(emilio)
Flags: needinfo?(emilio) → qe-verify-
You need to log in before you can comment on or make changes to this bug.