Closed Bug 1583958 Opened 1 year ago Closed 1 year ago

Update fdlibm import to pick up upstream fixes for bug 1583293 and bug 1583645

Categories

(Core :: JavaScript Engine, task, P1)

task

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: Waldo, Assigned: Waldo)

References

Details

Attachments

(23 files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review

Upstream accepted the patches to fix shift-related UB.

We apparently haven't updated our checkout since February of last year, so this is a bit of a mess. :-| Oh well.

Patching is going to proceed by munging the update script to download the new source but not apply local patches, then I'll go through our local patches manually applying them in successive revs til all are applied (and one new one has been added), then I'll un-munge the update script, then I'll run it in a no-op (save for updating README.mozilla). So this is going to be a 20-patch-long bomb. :-| Better than a single patch for all of it for clarity, IMO.

Blocks: 1583293, 1583645
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/autoland/rev/62e38ee5dd16
Update our fdlibm import to upstream rev cf4707bb2f78ecf56ba350bdc24e3135b4339622, adjusting local patchwork as necessary for changes upstream's made since last import.  r=arai

Looks like e_pow.cpp picked up some weak-reference macro goo that should be added to local patch 08, that I guess doesn't affect the build on Linux. :-| Will do and reland.

Flags: needinfo?(jwalden)
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/autoland/rev/e1df5d37a8dd
Update our fdlibm import to upstream rev cf4707bb2f78ecf56ba350bdc24e3135b4339622, adjusting local patchwork as necessary for changes upstream's made since last import.  r=arai
Assignee: nobody → jwalden
Status: NEW → ASSIGNED
Priority: -- → P1
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.