1583958 - Update fdlibm import to pick up upstream fixes for bug 1583293 and bug 1583645

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Jeff Walden [:Waldo]]

Upstream accepted the patches to fix shift-related UB.

Comment 1

[Jeff Walden [:Waldo]]

We apparently haven't updated our checkout since February of last year, so this is a bit of a mess. :-| Oh well.

Patching is going to proceed by munging the update script to download the new source but not apply local patches, then I'll go through our local patches manually applying them in successive revs til all are applied (and one new one has been added), then I'll un-munge the update script, then I'll run it in a no-op (save for updating README.mozilla). So this is going to be a 20-patch-long bomb. :-| Better than a single patch for all of it for clarity, IMO.

Comment 2

[Jeff Walden [:Waldo]]

Attachment: Bug 1583958 - Add an |exit 0| to the fdlibm update script before local patches are applied, then run |sh update.sh cf4707bb2f78ecf56ba350bdc24e3135b4339622| to update to latest tip. r=arai

Comment 3

[Jeff Walden [:Waldo]]

Attachment: Bug 1583958 - Apply local patch 01 so it applies to latest fdlibm checkout, then manually apply it. r=arai

Depends on D47157

Comment 4

[Jeff Walden [:Waldo]]

Attachment: Bug 1583958 - Apply local patch 02 so it applies to latest fdlibm checkout, then manually apply it. r=arai

Depends on D47158

Comment 5

[Jeff Walden [:Waldo]]

Attachment: Bug 1583958 - Apply local patch 03 so it applies to latest fdlibm checkout, then manually apply it. r=arai

Depends on D47159

Comment 6

[Jeff Walden [:Waldo]]

Attachment: Bug 1583958 - Apply local patch 04 so it applies to latest fdlibm checkout, then manually apply it. r=arai

Depends on D47160

Comment 7

[Jeff Walden [:Waldo]]

Attachment: Bug 1583958 - Apply local patch 05 so it applies to latest fdlibm checkout, then manually apply it. r=arai

Depends on D47161

Comment 8

[Jeff Walden [:Waldo]]

Attachment: Bug 1583958 - Apply local patch 06 so it applies to latest fdlibm checkout, then manually apply it. r=arai

Depends on D47162

Comment 9

[Jeff Walden [:Waldo]]

Attachment: Bug 1583958 - Apply local patch 07 so it applies to latest fdlibm checkout, then manually apply it. r=arai

Depends on D47163

Comment 10

[Jeff Walden [:Waldo]]

Attachment: Bug 1583958 - Apply local patch 08 so it applies to latest fdlibm checkout, then manually apply it. r=arai

Depends on D47164

Comment 11

[Jeff Walden [:Waldo]]

Attachment: Bug 1583958 - Apply local patch 09 so it applies to latest fdlibm checkout, then manually apply it. r=arai

Depends on D47165

Comment 12

[Jeff Walden [:Waldo]]

Attachment: Bug 1583958 - Apply local patch 10 so it applies to latest fdlibm checkout, then manually apply it. r=arai

Depends on D47166

Comment 13

[Jeff Walden [:Waldo]]

Attachment: Bug 1583958 - Apply local patch 11 so it applies to latest fdlibm checkout, then manually apply it. r=arai

Depends on D47167

Comment 14

[Jeff Walden [:Waldo]]

Attachment: Bug 1583958 - Apply local patch 12 so it applies to latest fdlibm checkout, then manually apply it. r=arai

Depends on D47168

Comment 15

[Jeff Walden [:Waldo]]

Attachment: Bug 1583958 - Apply local patch 13 so it applies to latest fdlibm checkout, then manually apply it. r=arai

Depends on D47169

Comment 16

[Jeff Walden [:Waldo]]

Attachment: Bug 1583958 - Apply local patch 14 so it applies to latest fdlibm checkout, then manually apply it. r=arai

Depends on D47170

Comment 17

[Jeff Walden [:Waldo]]

Attachment: Bug 1583958 - Apply local patch 15 so it applies to latest fdlibm checkout, then manually apply it. r=arai

Depends on D47171

Comment 18

[Jeff Walden [:Waldo]]

Attachment: Bug 1583958 - Apply local patch 16 so it applies to latest fdlibm checkout, then manually apply it. r=arai

Depends on D47172

Comment 19

[Jeff Walden [:Waldo]]

Attachment: Bug 1583958 - Apply local patch 17 so it applies to latest fdlibm checkout, then manually apply it. r=arai

Depends on D47173

Comment 20

[Jeff Walden [:Waldo]]

Attachment: Bug 1583958 - Apply local patch 18 so it applies to latest fdlibm checkout, then manually apply it. r=arai

Depends on D47174

Comment 21

[Jeff Walden [:Waldo]]

Attachment: Bug 1583958 - Add and apply a new local patch 19 that removes round-to-nearest-integer functions upstream added, that are not used by any of the files we use. r=arai

Depends on D47175

Comment 22

[Jeff Walden [:Waldo]]

Attachment: Bug 1583958 - Remove the early |exit 0| added to update.sh. r=arai

Depends on D47176

Comment 23

[Jeff Walden [:Waldo]]

Attachment: Bug 1583958 - Run |sh update.sh cf4707bb2f78ecf56ba350bdc24e3135b4339622| -- which now makes no (relative) changes save for updating the commit hash/timestamp in README.mozilla. r=arai

Depends on D47177

Comment 24

[Jeff Walden [:Waldo]]

Attachment: Bug 1583958 - Update our fdlibm import to upstream rev cf4707bb2f78ecf56ba350bdc24e3135b4339622, adjusting local patchwork as necessary for changes upstream's made since last import. r=arai

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62e38ee5dd16
Update our fdlibm import to upstream rev cf4707bb2f78ecf56ba350bdc24e3135b4339622, adjusting local patchwork as necessary for changes upstream's made since last import.  r=arai

Comment 26

[Andrei Ciure[:aciure]]

Backed out changeset 62e38ee5dd16 (bug 1583958) for causing build bustages

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=62e38ee5dd16ba4e0692b8537dc5254d29fba51c

backout: https://hg.mozilla.org/integration/autoland/rev/644e956b4de85cc5d446e5633fb6adce571fc1e5

Comment 27

[Jeff Walden [:Waldo]]

Looks like e_pow.cpp picked up some weak-reference macro goo that should be added to local patch 08, that I guess doesn't affect the build on Linux. :-| Will do and reland.

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1df5d37a8dd
Update our fdlibm import to upstream rev cf4707bb2f78ecf56ba350bdc24e3135b4339622, adjusting local patchwork as necessary for changes upstream's made since last import.  r=arai

Comment 29

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/e1df5d37a8dd