1583998 - Prototype a pref to obscure images

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Bobby Holley (:bholley)]

It would occasionally be nice to be able to debug sites without looking at image/video content. I've got a patch.

Comment 1

[Bobby Holley (:bholley)]

Attachment: Bug 1583998 - Refactor debug rectangles to allow the outer and inner colors to be explicitly specified.

The current code doesn't permit fully opaque debug rects.

Comment 2

[Bobby Holley (:bholley)]

Attachment: Bug 1583998 - Implement a pref to obscure images.

This approach does have some stacking issues. The way to fix this would
be to instrument the brush_image shader rather than adding debug rects.

Something like: #ifdef WR_FEATURE_SFW frag.color = vec4(0,1,1,1); #endif

That's slightly more involved though, so I'm going to leave it for now.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90162306864c
Refactor debug rectangles to allow the outer and inner colors to be explicitly specified. r=gw
https://hg.mozilla.org/integration/autoland/rev/f59ec3966f5f
Implement a pref to obscure images. r=gw

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/90162306864c
https://hg.mozilla.org/mozilla-central/rev/f59ec3966f5f