1584020 - Dimension overlay formats sizes as y-x, not x-y

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P3)

Description

[:Harald Kirschner :digitarald]

Reported via https://discourse.mozilla.org/t/ruler-functionality-in-dev-tools-provides-heightxwidth-instead-of-widthxheight/45817

Every other tool shows x/y order for dimensions.

Comment 1

[Julian Descottes [:jdescottes]]

Thanks for filing, looks like a good first bug!

Some pointers if anyone wants to pick this up:

• the label is created at https://searchfox.org/mozilla-central/rev/f43ae7e1c43a4a940b658381157a6ea6c5a185c1/devtools/server/actors/highlighters/rulers.js#296
• at least one test will need to be updated at https://searchfox.org/mozilla-central/source/devtools/client/inspector/test/browser_inspector_highlighter-rulers_03.js

Our developer docs are at https://docs.firefox-dev.tools/ and have all the information to setup the dev environment and start working on DevTools.

Comment 2

[Pranshu Chittora]

Hi Julian, I would like to take this up.

Comment 3

[Julian Descottes [:jdescottes]]

Hi!

Assigning the bug to you. As I mentioned in the previous comment. you can read the doc on https://docs.firefox-dev.tools/ to get started, but don't hesitate to ping me (here or on slack) if you need any help!

Note that you can use the "Request information from" input below the comment box to make sure the other person receives a notification.
It's the best way to make sure we don't forget to answer :)

Comment 4

[Julian Descottes [:jdescottes]]

Also adding some more context about the bug because it can be difficult to know which feature this is about.

To reproduce the bug you need to enable the "rulers" Toolbox button.

• open DevTools
• go to DevTools settings
• in Available Toolbox Buttons, check "Toggle rulers for the page"

This will add a rulers icon in the top right of the toolbox.

• click on the rulers icon
• the page dimension should now be displayed in the top right corner of the window

(will attach a screenshot as well)

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: bug_1584020_STRs.png

Comment 6

[Pranshu Chittora]

Attachment: Bug 1584020 - Dimension overlay formats sizes as y-x, from x-y r=jdescottes

Changes the format of dimensions in inspector to (Y - X) from (X - Y)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a4d6aacc480
Dimension overlay formats sizes as y-x, from x-y r=jdescottes

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/9a4d6aacc480