1584074 - CodeMirror display some tokens in black while in dark mode

Status: VERIFIED FIXED

(DevTools :: Source Editor, defect, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

See https://discourse.mozilla.org/t/nightly-dark-mode-brackets-and-dot-not-visible-in-the-dev-tools/45797
Looks like a recent regression (71.0a1 (2019-09-13) is fine)

Comment 1

[Andrei Petcu]

Found the bad commit :D

8:09.62 INFO: No more inbound revisions, bisection finished.
8:09.62 INFO: Last good revision: 9f2ff84ff3eef50321fe9525c6510e6462f519f0
8:09.62 INFO: First bad revision: 0e9caca3bcf6adf462ea5174be3f9d15ffe77b4c
8:09.62 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=9f2ff84ff3eef50321fe9525c6510e6462f519f0&tochange=0e9caca3bcf6adf462ea5174be3f9d15ffe77b4c

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Thanks for investigating!
The codemirror update is quite important, not sure what regressed

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1584074 - Fix CodeMirror token color issue due to update to v5.49.0. r=gl.

The last update of the CodeMirror library introduced new
CSS selectors in the css file with a greater specificity than
they used to, which means the color property we set in our
themes css files weren't applied.
We change the selectors in our theme files so they are more
specific than the ones in codemirror's css file.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d74f281194ea
Fix CodeMirror token color issue due to update to v5.49.0. r=gl.

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/d74f281194ea

Comment 8

[alex_mayorga]

¡Hola Stefan!

Verifying fixed as the duplicate https://bugzilla.mozilla.org/show_bug.cgi?id=1584044 is resolved on Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:71.0) Gecko/20100101 Firefox/71.0 ID:20191009103354

¡Gracias!
Alex