1584096 - [Windows] “Learn more” is not bolded in the Privacy Panel

Status: VERIFIED FIXED

(Firefox :: Protections UI, defect, P3)

Description

[Oana Botisan, Desktop QA]

Attachment: not bolded.png

Affected versions

• Firefox 71.a01
• Firefox 70.0b8

Affected platforms

• Windows 10 x64

Prerequisites:

• Firefox is launched.
• The user is sign in to FxA using at least two uncompromised or compromised accounts
• The user is sign in to https://monitor.firefox.com/ with the same account.

Steps to reproduce

1. Open any site with a new profile or click on the shield icon from URL bar and then on the "i" symbol.
2. Observe the "Learn more" hyperlink.

Expected result

• The hyperlink is bolded.

Actual result

• The hyperlink is not bolded.

Regression range

• This is not a regression.

Comment 1

[Jayati Shrivastava]

Hi! I would to like to work on this.

Comment 2

[Johann Hofmann [:johannh]]

Absolutely! If you need any starters, I would recommend inspecting the UI with the Browser Toolbox to find the "Learn More" element, then using Searchfox to figure out where the element is styled. We're happy to help if you have any questions, navigating the browser code can be challenging at first :)

Comment 3

[Jayati Shrivastava]

Attachment: Bug 1584096- changed font-weight for link text. r=prathiksha

Comment 4

[Jayati Shrivastava]

Attachment: After the fix

Does this now look as expected? do please review :)

Comment 5

[Jayati Shrivastava]

(In reply to Johann Hofmann [:johannh] from comment #2)

Absolutely! If you need any starters, I would recommend inspecting the UI with the Browser Toolbox to find the "Learn More" element, then using Searchfox to figure out where the element is styled. We're happy to help if you have any questions, navigating the browser code can be challenging at first :)

I have submitted the patch. Could you please review :)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d598b45de2fc
changed font-weight for link text. r=johannh

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d598b45de2fc

Comment 8

[Oana Botisan, Desktop QA]

Verified the fix using latest Nightly 86.0a1 and Firefox 85.0b1 on Windows 10 x64. The issue is not reproducing anymore.