Closed Bug 1584103 Opened 5 years ago Closed 5 years ago

[Windows] "Learn more about this breach" hyperlink from the warning panel is not bolded

Categories

(Firefox :: about:logins, defect, P3)

Product:
Firefox
Component:
about:logins
Platform:
All
Windows
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 71
Tracking Flags:
Tracking Status
firefox70 --- wontfix
firefox71 --- verified
firefox72 --- verified

People

(Reporter: obotisan, Assigned: jaws)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [passwords:management])

Attachments

(2 files)

Screenshot_3.png
5.91 KB, image/png
Details
Bug 1584103 - Increase the font-weight of the breach-alert-link to match the spec closer. r?MattN
47 bytes, text/x-phabricator-request
Details | Review
Attached image Screenshot_3.png —

Affected versions

  • Firefox 71.a01
  • Firefox 70.b9

Affected platforms

  • Windows 10 x64

Prerequisites

  • Have at least one breached site saved in the profile-- instructions on how to do this can be found here

Steps to reproduce

  1. Go to "about:logins".
  2. Observe the "Learn more about this breach" hyperlink from the warning panel.

Expected result

  • The hyperlink is bolded.

Actual result

  • The hyperlink is not bolded.

Regression range

  • This is a regression.
Component: Tracking Protection → Password Manager
Product: Firefox → Toolkit
Component: Password Manager → about:logins
Priority: -- → P3
Product: Toolkit → Firefox
Whiteboard: [passwords:management]

The font-weight here was incorrectly using 500, while all other "bold" fonts within about:logins use font-weight: 600.

Assignee: nobody → jaws
Status: NEW → ASSIGNED
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ab46062892d4
Increase the font-weight of the breach-alert-link to match the spec closer. r=MattN

https://hg.mozilla.org/mozilla-central/rev/ab46062892d4

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

Does this need a Beta uplift request before Monday's RC build?

Flags: needinfo?(jaws)

no, we're going to hold this for 71.

Flags: needinfo?(jaws)
Flags: qe-verify+

I verified the fix on Latest Nightly 72.0a1 and Firefox 71.0b5 on Windows 10 x64. The issue is not reproducing anymore.

Status: RESOLVED → VERIFIED
status-firefox71: fixed → verified
status-firefox72: --- → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: